Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve build system #194

Merged
merged 3 commits into from
Dec 22, 2020
Merged

ci: Improve build system #194

merged 3 commits into from
Dec 22, 2020

Conversation

simenandre
Copy link
Collaborator

@simenandre simenandre commented Nov 15, 2020

This pull request improves documentation for a release system based on Semantic Release.

Proposed release branches are as such:

  • develop should be considered as unstable code (not ready for production).
    e.g. v1.0.3-develop.5
  • next used for the next major version. e.g. v2.0.0-next.1 (not actively used until we need to)
  • main should be considered stable. e.g. v1.0.3

I have taken the liberty of updating some of the stylings on Markdown documents as well.

fixes #188

WARNING: The default branch should be changed to main before this pull request is merged.

@update-docs
Copy link

update-docs bot commented Nov 15, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #194 (bce2dd6) into alpha (845509d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines           50        50           
  Branches         3         3           
=========================================
  Hits            50        50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845509d...bce2dd6. Read the comment docs.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
simenandre and others added 2 commits November 16, 2020 21:32
Co-authored-by: Asbjørn Ulsberg <asbjorn.ulsberg@payex.com>
@simenandre simenandre changed the base branch from alpha to main November 17, 2020 07:56
Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simenandre
Copy link
Collaborator Author

simenandre commented Nov 17, 2020

@asbjornu can you change default branch to main? We'll wait until @NullableInt has reviewed as well, of course, before merging.

@asbjornu
Copy link
Contributor

Done.

Copy link
Contributor

@NullableInt NullableInt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@simenandre simenandre merged commit 626d417 into main Dec 22, 2020
@simenandre simenandre deleted the ci-cd branch December 22, 2020 21:51
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

NullableInt pushed a commit to NullableInt/swedbank-pay-js that referenced this pull request Jun 23, 2021
Co-authored-by: Asbjørn Ulsberg <asbjorn.ulsberg@payex.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development/development strategy
3 participants