New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache-on-failure support #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I will run the build from my system after merging, so you might want to remove the dist file changes from the PR
@@ -14,14 +14,17 @@ inputs: | |||
target-dir: | |||
description: "The target dir that should be cleaned and persisted, defaults to `./target`" | |||
required: false | |||
cache-on-failure: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put this into the readme as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Done |
Fixes #20
palfrey#1 demos this running. https://github.com/palfrey/rust-cache/runs/2926086671 for example is an earlier run with the cache being done despite the job failing (which then fails itself in that case because not enough Rust bits had run to make it viable)
The
dist
bits have been regenerated withnpm run prepare
but I'm seeing some notable changes?