Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache-on-failure support #22

Merged
merged 9 commits into from Jun 28, 2021
Merged

Cache-on-failure support #22

merged 9 commits into from Jun 28, 2021

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Jun 27, 2021

Fixes #20

palfrey#1 demos this running. https://github.com/palfrey/rust-cache/runs/2926086671 for example is an earlier run with the cache being done despite the job failing (which then fails itself in that case because not enough Rust bits had run to make it viable)

The dist bits have been regenerated with npm run prepare but I'm seeing some notable changes?

@palfrey palfrey marked this pull request as ready for review June 27, 2021 17:38
Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I will run the build from my system after merging, so you might want to remove the dist file changes from the PR

@@ -14,14 +14,17 @@ inputs:
target-dir:
description: "The target dir that should be cleaned and persisted, defaults to `./target`"
required: false
cache-on-failure:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this into the readme as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@palfrey
Copy link
Contributor Author

palfrey commented Jun 28, 2021

I will run the build from my system after merging, so you might want to remove the dist file changes from the PR

Done

@Swatinem Swatinem merged commit 536c94f into Swatinem:v1 Jun 28, 2021
@palfrey palfrey deleted the cache-on-failure branch June 28, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable optional save cache on failure
2 participants