Lock execjs to 2.7 in sandbox app
#70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExecJS released a minor version update with a breaking change. We want to lock to the previous version (2.7) for now until a fix is released. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Noah Silvera <noah@super.gd>
adammathys
approved these changes
May 17, 2021
|
Looks like the issue may already be resolved on Execjs' side: rails/execjs#99 |
|
@adammathys you are totally right. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecJS released a minor version update with a breaking change. We want
to lock to the previous version (2.7) for now until a fix is released.
What is the goal of this PR?
Fix the sandbox app
How do you manually test these changes? (if applicable)
bin/rails-sandbox sand hitlocalhost:3000Merge Checklist