Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deep Link for spaces with pin #103

Open
sync-by-unito bot opened this issue Aug 30, 2020 · 4 comments
Open

Fix Deep Link for spaces with pin #103

sync-by-unito bot opened this issue Aug 30, 2020 · 4 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 30, 2020

Scenarios to test on both browsers:

  • Open an invite join link for an space with password embedded.
  • Open an invite join link for an space with password not embedded.
  • Open an invite join link for an space without password.
  • Open an invite meet link for an space with password embedded.
  • Open an invite meet link for an space with password not embedded.
  • Open an invite meet link for an space without password.
  • Open a link to an space with password embedded (from copy link option)
  • Open a link to an space with password not embedded (from copy link option)
  • Open a link to an space without password (from copy link option)
  • Open a link to an personal room without password (from copy link option)
  • Open a link to an personal room with password embedded (from copy link option)
  • Open a link to an personal room with password not embedded (from copy link option)

Testing is performed on Chrome and Safari for all scenarios with both options, Continue in browser, Remember this decision (on Chrome) and Open Desktop App.

This allows to validate these issues:
#84 ⁃ loganstaging.esna.com - Deep linking - Desktop app space infinite loading screen
#85 ⁃ loganstaging.esna.com -Deep Link - Links with embedded pin do not work on app
[Tho-Aug 31] issue still happens. Comment, logs, screenshots, video clip were added to item
#100 ⁃ spaces-candidate.avayacould.com - App 1.1.15 - People roster does not update when guest user in app switches between spaces
#99 ⁃ Avaya Spaces (1.1.15-staging) is not loaded if saved account is different to one in invited email
[Tho-Aug 31] issue still happens. Comment, logs, screenshots, video clip were added to item
#104 ⁃ System loganstaging.esna.com - Changing option to "Ask every time" causes the user is kicked out of current space or on-going meeting
#105 ⁃ System loganstaging.esna.com - Refresh page and access space with "Continue in browser", user sees false audio status of existing user in meeting

Builds of Electron app for macOS and Windows for the following envs:

  • local
  • staging
  • candidate

could be found here https://drive.google.com/drive/folders/1yqklulf0XDheOsqn466DK4Ikj0fcFgh5?usp=sharing

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 30, 2020

➤ Flavio Peralta commented:

PR: https://github.com/esna/spaces-front/pull/3448

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 30, 2020

➤ Flavio Peralta commented:

@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) PR is updated with the suggested changes and implementation.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 30, 2020

➤ Flavio Peralta commented:

@tho Pham ( https://app.asana.com/0/1151199909755310/list ) please use the Electron App installers from here https://drive.google.com/file/d/1gBlXAt5zMpCKT7ldoaD9FLvHtkP5Q_bg/view?usp=sharing.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 31, 2020

➤ Tho Pham commented:

Hi @flavio Peralta ( https://app.asana.com/0/1182240586515905/list ),

I retested items #85, #99 and issues still happen. Please check comments and logs on each item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants