Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spaces-candidate.avayacloud.com - Deep linking - Desktop app space infinite loading screen #84

Open
sync-by-unito bot opened this issue Aug 27, 2020 · 5 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 27, 2020

Description:

  1. user1 invites user2 as guest to pin protected, embedded pin disabled space.
  2. User2 clicks the invite link in email and is taken to the landing page to choose between dekstop app or webpage
  3. User2 chooses desktop app.
  4. App opens, user2 enters pin and enters space.
  5. User2 closes the app and chooses desktop app again on the landing page.
  6. infinte loading screen

Expected behavior
User2 should be prompted to enter pin again instead of being stuck with infinite loading screen

please use the Electron App installers from here https://drive.google.com/file/d/1gBlXAt5zMpCKT7ldoaD9FLvHtkP5Q_bg/view?usp=sharing.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 28, 2020

➤ Umair Aslam commented:

The fix will be on both electron app and spaces-front.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 28, 2020

➤ Flavio Peralta commented:

@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) here is the PR with the workaround fix we talked about to load the URL that comes on deep link instead of perform an internal routing https://github.com/esna/spaces-front/pull/3444. This is a minor change on electron app side only.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 28, 2020

➤ Ray Gerami commented:

@Umair Aslam ( https://app.asana.com/0/1153071673779409/calendar ), please wait on this PR until we make our decision on the Plan A or B. This Fix is good for Plan A

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 28, 2020

➤ Umair Aslam commented:

@ray Gerami ( https://app.asana.com/0/1154145881585295/calendar )@flavio Peralta ( https://app.asana.com/0/1182240586515905/list ) SInce we are doing Plan B now, I am assigning it back to Flavio.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 30, 2020

➤ Flavio Peralta commented:

PR is on #103 ⁃ Fix Deep Link for spaces with pin ( https://app.asana.com/0/1183131807549409/1191323627363921/f )

@sync-by-unito sync-by-unito bot changed the title loganstaging.esna.com - Deep linking - Desktop app space infinite loading screen spaces-candidate.avayacloud.com - Deep linking - Desktop app space infinite loading screen Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants