Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use @next/swc for transpiling files #6

Draft
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

SukkaW
Copy link
Owner

@SukkaW SukkaW commented Jun 19, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@SukkaW
Copy link
Owner Author

SukkaW commented Jun 19, 2022

@ijjk

Here is my attempt to use @next/swc for precompiling. Here are the problems I currently encounter and my thoughts:

Snipaste_2022-06-20_01-12-04

  • @next/swc-* is published alongside Next.js. If there is a bug in @next/swc causing pre-compiled files to corrupt, and we accidentally release a defected version of Next.js, we can not fix pre-compiled files with the latest @next/swc-* without publishing another new version of Next.js.
    • If we still use @swc/core, we can update @swc/core separately, without bumping the version of @next/swc-*
  • When @vercel/ncc switches to swc-loader, it will also require @swc/core to be installed as a devDependency anyway.

@SukkaW SukkaW marked this pull request as draft August 29, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant