fix(vercel#34030): ignore non-checkable jsx spread attribute

SukkaW · Feb 17, 2022 · 5be9cb4 · 5be9cb4
1 parent ba78437
commit 5be9cb4
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/packages/eslint-plugin-next/lib/rules/inline-script-id.js b/packages/eslint-plugin-next/lib/rules/inline-script-id.js
@@ -28,16 +28,30 @@ module.exports = {
         }
 
         const attributeNames = new Set()
+
+        let hasNonCheckableSpreadAttribute = false
         node.openingElement.attributes.forEach((attribute) => {
+          // Early return if we already have a non-checkable spread attribute, for better performance
+          if (hasNonCheckableSpreadAttribute) return
+
           if (attribute.type === 'JSXAttribute') {
             attributeNames.add(attribute.name.name)
           } else if (attribute.type === 'JSXSpreadAttribute') {
-            attribute.argument.properties.forEach((property) => {
-              attributeNames.add(property.key.name)
-            })
+            if (attribute.argument?.properties) {
+              attribute.argument.properties.forEach((property) => {
+                attributeNames.add(property.key.name)
+              })
+            } else {
+              // JSXSpreadAttribute without properties is not checkable
+              hasNonCheckableSpreadAttribute = true
+            }
           }
         })
 
+        // https://github.com/vercel/next.js/issues/34030
+        // If there is a non-checkable spread attribute, we simply ignore them
+        if (hasNonCheckableSpreadAttribute) return
+
         if (
           node.children.length > 0 ||
           attributeNames.has('dangerouslySetInnerHTML')