Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic compute plan #21

Merged
merged 12 commits into from Dec 5, 2019
Merged

Generic compute plan #21

merged 12 commits into from Dec 5, 2019

Conversation

jmorel
Copy link
Contributor

@jmorel jmorel commented Nov 28, 2019 •
edited

Add 2 tests for generic compute plans:

  • make sure circular dependencies are handled correctly
  • duplicate the test_aggregate_composite_traintuples in a compute plan

This required to update factory.py quite a bit.

@jmorel jmorel changed the base branch from master to feature/generic-composite November 28, 2019 14:46
@jmorel jmorel marked this pull request as ready for review November 29, 2019 07:47
@jmorel jmorel mentioned this pull request Nov 29, 2019
Merged
inalgnu
inalgnu reviewed Dec 2, 2019
View reviewed changes
tests/test_execution_compute_plan.py Outdated

# TODO make sur the creation is rejected
cp = session.add_compute_plan(cp_spec)
assert False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOF

@inalgnu inalgnu changed the base branch from feature/generic-composite to master December 2, 2019 13:07
samlesu
samlesu requested changes Dec 3, 2019
View reviewed changes
substratest/assets.py Outdated Show resolved Hide resolved
substratest/assets.py Outdated Show resolved Hide resolved
substratest/assets.py Show resolved Hide resolved
substratest/factory.py Outdated Show resolved Hide resolved
substratest/assets.py Outdated Show resolved Hide resolved
samlesu
samlesu requested changes Dec 3, 2019
View reviewed changes
substratest/assets.py Outdated Show resolved Hide resolved
substratest/assets.py Outdated Show resolved Hide resolved
substratest/factory.py Outdated Show resolved Hide resolved
tests/test_execution_compute_plan.py Outdated Show resolved Hide resolved
tests/test_execution_compute_plan.py Outdated Show resolved Hide resolved
substratest/assets.py Show resolved Hide resolved
samlesu
samlesu reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@samlesu samlesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samlesu
samlesu reviewed Dec 4, 2019
View reviewed changes
substratest/factory.py Outdated Show resolved Hide resolved
substratest/factory.py Show resolved Hide resolved
samlesu
samlesu requested changes Dec 4, 2019
View reviewed changes
substratest/assets.py Outdated Show resolved Hide resolved
samlesu
samlesu reviewed Dec 5, 2019
View reviewed changes
substratest/assets.py Outdated Show resolved Hide resolved
samlesu
samlesu reviewed Dec 5, 2019
View reviewed changes
substratest/assets.py Outdated Show resolved Hide resolved
@inalgnu inalgnu requested a review from samlesu December 5, 2019 09:44
@inalgnu inalgnu merged commit e5b069c into master Dec 5, 2019
@inalgnu inalgnu deleted the generic-compute-plan branch December 5, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienGasser AurelienGasser AurelienGasser left review comments

@inalgnu inalgnu inalgnu approved these changes

@samlesu samlesu samlesu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmorel @AurelienGasser @inalgnu @samlesu