Add null type to currentFile in JSZipMetadata #851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to combine those types. I've made #852, could you take a look and see if that would fix the issue? |
|
Yes, you are right - that is a much nicer solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was supposed to be done as part of PR #826.
At the moment
OnUpdateCallbackandMetadataare not exported so I had to rely onJSZip.JSZipMetadatafor a typesafeonUpdatecallback togenerateAsync. However,JSZip.JSZipMetadataisn't exactly identical toMetadataasMetadatahas a union type that allowscurrentfileto benull. I see this was added in PR #826 , but shouldn't it be added to both types?