Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use a null prototype object for this.files #766

Merged
merged 3 commits into from Jun 29, 2021
Merged

fix: Use a null prototype object for this.files #766

merged 3 commits into from Jun 29, 2021

Commits on Jun 14, 2021

  1. fix: Use a null prototype object for this.files 

    This approach is taken to prevent overriding object methods that would
exist on a normal object Object.create({})
    @MichaelAquilina
    MichaelAquilina committed Jun 14, 2021
    2
    Copy the full SHA
    2235749 View commit details
    Browse the repository at this point in the history

  2. test: Add test case for loading zip filenames which shadow method names

    @MichaelAquilina
    MichaelAquilina committed Jun 14, 2021
    Copy the full SHA
    d024c22 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Ensure prototype isn't modified by zip file

    @Stuk
    Stuk committed Jun 23, 2021
    Copy the full SHA
    bb38812 View commit details
    Browse the repository at this point in the history