Make this complete to run tests locally. #638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add latest smallest jquery-3.4.1.slim.min.js Fix pathways in ./index.html. Now, ./index.html working after run this from folder. Add /dist/jszip-utils.js fix protocols and pathways in ./test/index.html. Add warning there, in the top of the page.
|
Maybe, need to add another scripts from ./test/index.html, which are loading from another resources. After many years, this resources can be not available, but if this scripts will be downloaded and added to repositary, then jszip will be complete. |
Because Jquery already exists in `./test/jquery-1.8.3.min.js`
Move this to `./test/vendor/`-
Replace old Jquery `./test/vendor/jquery-1.8.3.min.js` (93,637 bytes) to latest minified of JQuery-slim: `./test/vendor/jquery-3.4.1.slim.min.js` (71,037 bytes). Add `qunit-1.23.0.js` and `qunit-1.23.0.css` to the `./test/vendor`-folder. Change pathways for this files, in `index.html` and `./test/index.html`.
username1565
changed the title
|
Done. Now this code may to be complete. |
Changes:
Added windows-1251 and DOS(cp866) encoding to correct encode-decode the ciryllic symbols on Windows.
Now this specified in params, as
{encoding: "windows-1251"},
{encoding: "Windows-1251"},
{encoding: "cp866"},
Added third case:
{encoding: "pathways_and_filenames-encoding-is-cp866_password-encoding-is-windows-1251"},
when pathway encoding is cp866 but encoding for password is windows-1251.
Default encoding for txt-file content is not changed, but now this can be a string, not buffer of bytearray.
Maybe all encoders need to be added in separate module and .js-script, and using only hex(bytes), as values on input-ouptut.
Here, you can see cyrillic-symbols in pathway (filename), and password.
This is compressing, and uncompressing sucessfully, by using this script.
abc_пароль.zip - zip-file, which was been generated by this script.
make_array_with_bytes.html - the page to return hexdump - "array_with_bytes.txt", after uploding binary file.
smaller_array_with_bytes.txt - array, without many "0x00" bytes, in the end.
I don't know how to write this in C-code, because as I understand, minizip-asm.min.js is generated from C-code.
But anyway, anyone can read this, understand this, see differences, and fix this by more qualified way.
Remove file from commit username1565/minizip-asm.js@64b827f
Remove file from commit username1565/minizip-asm.js@64b827f
Remove file from commit username1565/minizip-asm.js@64b827f
Remove file from commit username1565/minizip-asm.js@64b827f
Remove file from commit username1565/minizip-asm.js@64b827f
Remove file from commit username1565/minizip-asm.js@64b827f
Remove file from commit username1565/minizip-asm.js@64b827f
Remove file from commit username1565/minizip-asm.js@64b827f
|
Sorry, previous files was been uploaded here, by my mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add latest smallest jquery-3.4.1.slim.min.js
Fix pathways in ./index.html. Now, ./index.html working after run this from folder.
Add /dist/jszip-utils.js
fix protocols and pathways in ./test/index.html. Add warning there, in the top of the page.