Merge pull request #544 from mljsgto222/invalid_extra_field_data

Fixed 'End of data reached' error when file extra field is invalid
Stuk · Jun 13, 2020 · ed8a758 · ed8a758
2 parents bead269 + 7a99db8
commit ed8a758
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/lib/zipEntry.js b/lib/zipEntry.js
@@ -200,7 +200,7 @@ ZipEntry.prototype = {
             this.extraFields = {};
         }
 
-        while (reader.index < end) {
+        while (reader.index + 4 < end) {
             extraFieldId = reader.readInt(2);
             extraFieldLength = reader.readInt(2);
             extraFieldValue = reader.readData(extraFieldLength);
@@ -211,6 +211,8 @@ ZipEntry.prototype = {
                 value: extraFieldValue
             };
         }
+
+        reader.setIndex(end);
     },
     /**
      * Apply an UTF8 transformation if needed.

diff --git a/test/asserts/load.js b/test/asserts/load.js
@@ -570,6 +570,18 @@ QUnit.module("load", function () {
         });
     });
 
+    JSZipTestUtils.testZipFile("zip file with extra field is Non-standard", "ref/extra_filed_non_standard.zip", function(assert, file) {
+        var done = assert.async();
+        JSZip.loadAsync(file)
+        .then(function success() {
+            assert.ok(true, "no exception were thrown");
+            done();
+        }, function failure(e) {
+            assert.ok(false, "An exception were thrown: " + e.message);
+            done();
+        });
+    });
+
     QUnit.test("not a zip file", function(assert) {
         var done = assert.async();
         JSZip.loadAsync("this is not a zip file")

diff --git a/test/ref/extra_filed_non_standard.zip b/test/ref/extra_filed_non_standard.zip