Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace structopt with clap #384

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

Expyron
Copy link
Contributor

@Expyron Expyron commented Sep 15, 2022

No description provided.

@Stranger6667
Copy link
Owner

What is the reason for this change?

@Expyron
Copy link
Contributor Author

Expyron commented Sep 15, 2022

Structopt is not maintained anymore: TeXitoi/structopt#525
Its author recommends moving to clap v3.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #384 (84ed9c9) into master (5da8685) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   82.50%   82.52%   +0.01%     
==========================================
  Files          57       57              
  Lines        5562     5579      +17     
==========================================
+ Hits         4589     4604      +15     
- Misses        973      975       +2     
Impacted Files Coverage Δ
jsonschema/src/main.rs 0.00% <ø> (ø)
jsonschema/src/keywords/format.rs 88.63% <78.57%> (-0.61%) ⬇️
jsonschema/src/compilation/options.rs 87.34% <100.00%> (+0.21%) ⬆️
jsonschema/src/error.rs 64.14% <0.00%> (ø)
jsonschema/src/lib.rs 82.43% <0.00%> (+1.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Julian
Copy link

Julian commented Sep 17, 2022

As is I think this also is triggering GitHub security warnings for users of jsonschema-rs -- e.g. on bowtie, due to the transitive dependency on ansi_term, I see:

Screen Shot 2022-09-17 at 14 47 01

EDIT: It seems the advisory was now retracted, so the above isn't true anymore.

@Stranger6667 Stranger6667 merged commit 07be2ff into Stranger6667:master Oct 18, 2022
@Stranger6667
Copy link
Owner

Sorry for the delay! Merged :) I'll make a new release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants