fix(#26): unify naming

implementation/retry/retry.go

@@ -28,23 +28,23 @@ type RetryImpl struct {
 	SilenceGivingUp bool
 }
 
-func NewWithOpts(
+func NewWithOptions(
 	wrapped aurestclientapi.Client,
 	condition aurestclientapi.RetryConditionCallback,
-	options RetryOptions,
+	opts RetryOptions,
 ) aurestclientapi.Client {
 	repeatCount := uint8(2)
-	if options.RepeatCount > 0 {
-		repeatCount = options.RepeatCount
+	if opts.RepeatCount > 0 {
+		repeatCount = opts.RepeatCount
 	}
 	return &RetryImpl{
 		Wrapped:                 wrapped,
 		RepeatCount:             repeatCount,
 		RetryCondition:          condition,
-		BeforeRetry:             options.BeforeRetryOrNil,
+		BeforeRetry:             opts.BeforeRetryOrNil,
 		RetryingMetricsCallback: doNothingMetricsCallback,
 		GivingUpMetricsCallback: doNothingMetricsCallback,
-		SilenceGivingUp:         options.SilenceGivingUp,
+		SilenceGivingUp:         opts.SilenceGivingUp,
 	}
 }
 

implementation/retry/retry_test.go

@@ -131,7 +131,7 @@ func TestFailWithRetryWithOpts(t *testing.T) {
 	aulogging.SetupNoLoggerForTesting()
 
 	mock := tstMock()
-	cut := NewWithOpts(mock,
+	cut := NewWithOptions(mock,
 		func(ctx context.Context, response *aurestclientapi.ParsedResponse, err error) bool {
 			return true
 		},