Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated copyright headers, fix code coverage reports #345

Merged
merged 2 commits into from Jun 3, 2020
Merged

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jun 1, 2020

  • Update copyright headers to be a bit more streamlined and point to the full license file
  • Improve CI pipeline to address loss of code coverage due to enabling deterministic builds

@TimHess TimHess added the ReleaseLine/2.x Identified as a feature/fix for the 2.x release line label Jun 1, 2020
@TimHess TimHess requested a review from jkonicki June 1, 2020 19:07
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #345 into 2.x will decrease coverage by 10.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              2.x     #345       +/-   ##
===========================================
- Coverage   81.48%   71.17%   -10.31%     
===========================================
  Files           3      804      +801     
  Lines          27    23176    +23149     
  Branches        3     4222     +4219     
===========================================
+ Hits           22    16496    +16474     
- Misses          5     5508     +5503     
- Partials        0     1172     +1172     
Impacted Files Coverage Δ
...x.MetricsEventsCore/CancellationTokenExtensions.cs 100.00% <ø> (ø)
...sCore/Controllers/HystrixConfigStreamController.cs 100.00% <ø> (ø)
...Core/Controllers/HystrixMetricsStreamController.cs 100.00% <ø> (ø)
...Controllers/HystrixRequestEventStreamController.cs 100.00% <ø> (ø)
...ntsCore/Controllers/HystrixStreamBaseController.cs 74.00% <ø> (ø)
.../Controllers/HystrixUtilizationStreamController.cs 100.00% <ø> (ø)
...sEventsCore/HystrixApplicationBuilderExtensions.cs 0.00% <ø> (ø)
...csEventsCore/HystrixServiceCollectionExtensions.cs 91.30% <ø> (ø)
...StreamAutofac/HystrixContainerBuilderExtensions.cs 40.00% <ø> (ø)
...tricsStreamAutofac/RabbitMetricsStreamPublisher.cs 14.28% <ø> (ø)
... and 975 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f30acb...b74026f. Read the comment docs.

@TimHess TimHess force-pushed the copyright branch 5 times, most recently from a9c8e9d to e9cb44a Compare June 2, 2020 17:37
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TimHess
Copy link
Member Author

TimHess commented Jun 2, 2020

CodeCov will fail until this PR is merged: codecov/codecov-exe#105

@TimHess TimHess changed the title Use streamlined, dateless copyright headers Updated copyright headers, fix code coverage reports Jun 3, 2020
@TimHess TimHess added this to the 2.4.4 milestone Jun 3, 2020
@jkonicki
Copy link
Contributor

jkonicki commented Jun 3, 2020

Copyright update looks good. I think you need to fix the comment referring to 3.1.300 to post 3.1.300, since it doesn't address all the problems we have.

Copy link
Contributor

@jkonicki jkonicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the note about the 3.1.300 to post-3.1.300

@TimHess TimHess merged commit 0175551 into 2.x Jun 3, 2020
@TimHess TimHess deleted the copyright branch June 3, 2020 17:14
@TimHess TimHess self-assigned this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/2.x Identified as a feature/fix for the 2.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants