win: Add WinConsoleInfo struct #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parallel API to terminfo terminals is also added: * WinConsoleInfo::from_env() * WinConsole::new_with_consoleinfo() Just like terminfo, this allows to check if we are going to get errors before moving `out`. Related: Stebalien#57 Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
Stebalien
requested changes
Aug 20, 2018
src/win.rs
Outdated
| pub fn new_with_consoleinfo(out: T, consoleinfo: WinConsoleInfo) -> WinConsole<T> { | ||
| WinConsole { | ||
| buf: out, | ||
| def_foreground: consoleinfo.def_foreground, |
There was a problem hiding this comment.
I'd modify the WinConsole struct itself to embed a WinConsoleInfo.
There was a problem hiding this comment.
Right. I thought a smaller diff would be better.
Are you okay the idea behind the change?
There was a problem hiding this comment.
Definitely. This brings the windows/unix interfaces closer together without breaking the API in any way.
There was a problem hiding this comment.
Done.
If you ever have the time. Your feedback about term-string would be greatly appreciated.
There was a problem hiding this comment.
I'll take a look when I get a chance.
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
Stebalien
approved these changes
Aug 20, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel API to terminfo terminals is also added:
Just like terminfo, this allows to check if we are going to get
errors before moving
out.Related: #57