-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and fix builds #123
Conversation
The mem::replace idiom was unneeded, so replace it with more direct code. This fixes the lint issues breaking the build on master.
Updates to latest major (or minor for <0 releases) versions of dependencies.
1.32 was released in Jan 2019 and set as MSRV a year ago; 1.41 was released a year after 1.32, giving about the same gap between release and setting it as MSRV.
What's the motivation for the new MSRV? |
Required to pass CI, without it there are a tonne of errors from use of unstabilised things. Coming up from crossbeam I think, via remove_dir_all's new parallel codepath on windows that I added in 0.6. https://ci.appveyor.com/project/Stebalien/tempfile/builds/34838839
|
Oh, I see. |
Ok; that wasn't clear. I can't do this immediately, but:... - for rustups test suite we'd benefit from the performance improvements the remove_dir_all new codepath has being offered from tempfile as well. The primary reason to add that was for the toolchain component removal codepath - removing 10's of thousands of files serially was awfully slow. We would also benefit from this parallel removal codepath in our test suites use of tempfile. What if the remove_dir_all parallelism was controlled via a feature, so tempfile could default to a conservative serial behaviour and serial dependencies, and users of tempfile could opt into faster behaviour, with the associated dependencies and complexity. |
Oh, and I've split out the master-fixing patch to #124 for you while we figure out what to do with remove_dir_all |
An opt-in feature works. My concern is that, by default at least, a temporary file library needs to be:
However, if the user explicitly opts in to removing files in parallel, that's their choice. I'd still prefer it if it were completely opt-in as anyone explicitly pulling in |
No description provided.