Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More ergonomic support for using a unix socket with a tonic server #1
More ergonomic support for using a unix socket with a tonic server #1
Changes from all commits
46650c4
c1719c1
22d1f1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How easy would it be to make
Endpoint::try_from("unix:///tmp/uds-integration-test)
work without the fake url/custom connector? Probably fine to punt.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this would get a bit hairy as implementing something in
Endpoint
would bubble back up thoughtonic::transport::Channel
andtonic::transport::service::Connection
and we'd have to find some way to handle an optional URI inside anEndpoint
through those (and update tests, etc). Seems like more trouble than it's worth considering this only saves consumers 1 LOC (although I do realize it is awkward)