Bump minitest from 5.22.2 to 5.23.0 #630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
gem compare minitest 5.22.2 5.23.0Compared versions: ["5.22.2", "5.23.0"]
DIFFERENT date:
5.22.2: 2024-02-07 00:00:00 UTC
5.23.0: 2024-05-15 00:00:00 UTC
DIFFERENT version:
5.22.2: 5.22.2
5.23.0: 5.23.0
DIFFERENT files:
5.22.2->5.23.0:
* Added:
lib/minitest/error_on_warning.rb +11/-0
(!) Unexpected permissions: 100444
lib/minitest/manual_plugins.rb +16/-0
(!) Unexpected permissions: 100444
* Changed:
History.rdoc +12/-0
Manifest.txt +2/-0
README.rdoc +15/-13
Rakefile +6/-0
lib/minitest.rb +36/-4
lib/minitest/pride_plugin.rb +7/-10
lib/minitest/test.rb +4/-3
lib/minitest/test_task.rb +1/-1
test/minitest/metametameta.rb +19/-5
test/minitest/test_minitest_assertions.rb +26/-23
test/minitest/test_minitest_mock.rb +15/-13
test/minitest/test_minitest_reporter.rb +13/-13
test/minitest/test_minitest_spec.rb +19/-17
test/minitest/test_minitest_test.rb +21/-21
test/minitest/test_minitest_test_task.rb +2/-0
DIFFERENT extra_rdoc_files:
5.22.2->5.23.0:
* Changed:
History.rdoc +12/-0
Manifest.txt +2/-0
README.rdoc +15/-13 |
gem compare --diff minitest 5.22.2 5.23.0Compared versions: ["5.22.2", "5.23.0"]
DIFFERENT files:
5.22.2->5.23.0:
* Added:
(!) Unexpected permissions: 100444
(!) Unexpected permissions: 100444
lib/minitest/error_on_warning.rb
--- /tmp/20240516-1904-l8g87f 2024-05-16 02:40:24.372036211 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/lib/minitest/error_on_warning.rb 2024-05-16 02:40:24.368036223 +0000
@@ -0,0 +1,11 @@
+module Minitest
+
+ module ErrorOnWarning
+ def warn(message, category: nil)
+ message = "[#{category}] #{message}" if category
+ raise UnexpectedWarning, message
+ end
+ end
+
+ ::Warning.singleton_class.prepend(ErrorOnWarning)
+end
lib/minitest/manual_plugins.rb
--- /tmp/20240516-1904-v1nrp2 2024-05-16 02:40:24.372036211 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/lib/minitest/manual_plugins.rb 2024-05-16 02:40:24.368036223 +0000
@@ -0,0 +1,16 @@
+require "minitest"
+
+ARGV << "--no-plugins"
+
+module Minitest
+ ##
+ # Manually load plugins by name.
+
+ def self.load *names
+ names.each do |name|
+ require "minitest/#{name}_plugin"
+
+ self.extensions << name.to_s
+ end
+ end
+end
* Changed:
History.rdoc
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/History.rdoc 2024-05-16 02:40:24.356036259 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/History.rdoc 2024-05-16 02:40:24.364036235 +0000
@@ -0,0 +1,12 @@
+=== 5.22.3 / 2024-03-13
+
+* 1 minor enhancement:
+
+ * MASSIVE improvement of minitest's pride plugin output: Frequencies doubled! Sine waves shifted!! Comments improved!!! Colors rotated!!!! (havenwood)
+
+* 3 bug fixes:
+
+ * Improved wording on Minitest::Test#parallelize_me! to clarify it goes INSIDE your test class/describe.
+ * Minor changes to tests to pass when tests ran with extra flags (eg -p).
+ * Support Ruby 3.4's new error message format. (mame)
+
Manifest.txt
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/Manifest.txt 2024-05-16 02:40:24.360036247 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/Manifest.txt 2024-05-16 02:40:24.364036235 +0000
@@ -12,0 +13 @@
+lib/minitest/error_on_warning.rb
@@ -14,0 +16 @@
+lib/minitest/manual_plugins.rb
README.rdoc
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/README.rdoc 2024-05-16 02:40:24.360036247 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/README.rdoc 2024-05-16 02:40:24.364036235 +0000
@@ -409 +409 @@
-Minitest is a dependency of rails, which until fairly recently had an
+Minitest is a dependency of rails, which until very recently had an
@@ -415 +415 @@
-(As of 2023-03-05)
+(As of 2024-05-10)
@@ -419,6 +419,7 @@
- | rails | min ruby | rec ruby | minitest | status | EOL Date |
- |-------+----------+----------+----------+----------+------------|
- | 7.0 | >= 2.7 | 3.1 | >= 5.1 | Current | 2025-06-01?|
- | 6.1 | >= 2.5 | 3.0 | >= 5.1 | Maint | 2024-06-01?|
- | 6.0 | >= 2.5 | 2.6 | >= 5.1 | Security | 2023-06-01 |
- | 5.2 | >= 2.2.2 | 2.5 | ~> 5.1 | EOL | 2022-06-01 |
+ | rails | min ruby | minitest | status | EOL Date |
+ |-------+----------+----------+----------+------------|
+ | 7.1 | >= 2.7 | >= 5.1 | Current | 2026-06-01?|
+ | 7.0 | >= 2.7 | >= 5.1 | Maint | 2025-06-01?|
+ | 6.1 | >= 2.5 | >= 5.1 | Security | 2024-06-01?|
+ | 6.0 | >= 2.5 | >= 5.1 | EOL | 2023-06-01 |
+ | 5.2 | >= 2.2.2 | ~> 5.1 | EOL | 2022-06-01 |
@@ -434,4 +435,5 @@
- | 3.2 | Current | 2026-03-31 |
- | 3.1 | Maint | 2025-03-31 |
- | 3.0 | Maint | 2024-03-31 |
- | 2.7 | Security| 2023-03-31 |
+ | 3.3 | Current | 2027-03-31 |
+ | 3.2 | Maint | 2026-03-31 |
+ | 3.1 | Security| 2025-03-31 |
+ | 3.0 | EOL | 2024-03-31 |
+ | 2.7 | EOL | 2023-03-31 |
@@ -439 +441 @@
- | 2.5 | EOL | 2021-03-31 |
+ | 2.5 | EOL | 2021-03-31 | DO YOU SEE WHAT I'M STUCK WITH???
Rakefile
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/Rakefile 2024-05-16 02:40:24.360036247 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/Rakefile 2024-05-16 02:40:24.364036235 +0000
@@ -35,0 +36 @@
+ /(must|wont)_pattern/ => '\1_pattern_match',
@@ -72,0 +74,5 @@
+end
+
+Minitest::TestTask.create :testW0 do |t|
+ t.warning = false
+ t.test_prelude = "$-w = nil"
lib/minitest.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/lib/minitest.rb 2024-05-16 02:40:24.360036247 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/lib/minitest.rb 2024-05-16 02:40:24.364036235 +0000
@@ -12 +12 @@
- VERSION = "5.22.2" # :nodoc:
+ VERSION = "5.22.3" # :nodoc:
@@ -170 +169,0 @@
- return empty_run! options if summary && summary.count == 0
@@ -173,0 +173 @@
+ return empty_run! options if summary && summary.count == 0
@@ -255,0 +256,14 @@
+ ruby27plus = ::Warning.respond_to?(:[]=)
+
+ opts.on "-W[error]", String, "Turn Ruby warnings into errors" do |s|
+ options[:Werror] = true
+ case s
+ when "error", "all", nil then
+ require "minitest/error_on_warning"
+ $VERBOSE = true
+ ::Warning[:deprecated] = true if ruby27plus
+ else
+ ::Warning[s.to_sym] = true if ruby27plus # check validity of category
+ end
+ end
+
@@ -785,0 +800,5 @@
+ # Total number of tests that warned.
+
+ attr_accessor :warnings
+
+ ##
@@ -799,0 +819 @@
+ self.warnings = nil
@@ -827,0 +848 @@
+ self.warnings = aggregate[UnexpectedWarning].size
@@ -902,0 +924,2 @@
+ extra.prepend ", %d warnings" % [warnings] if options[:Werror]
+
@@ -963 +986 @@
- RE = /in .(?:assert|refute|flunk|pass|fail|raise|must|wont)/ # :nodoc:
+ RE = /in [`'](?:[^']+[#.])?(?:assert|refute|flunk|pass|fail|raise|must|wont)/ # :nodoc:
@@ -1037,0 +1061,9 @@
+ # Assertion raised on warning when running in -Werror mode.
+
+ class UnexpectedWarning < Assertion
+ def result_label # :nodoc:
+ "Warning"
+ end
+ end
+
+ ##
@@ -1110 +1142 @@
- MT_RE = %r%lib/minitest% #:nodoc:
+ MT_RE = %r%lib/minitest|internal:warning% #:nodoc:
lib/minitest/pride_plugin.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/lib/minitest/pride_plugin.rb 2024-05-16 02:40:24.360036247 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/lib/minitest/pride_plugin.rb 2024-05-16 02:40:24.368036223 +0000
@@ -116,3 +116,2 @@
- # 6 has wide pretty gradients. 3 == lolcat, about half the width
- @colors = (0...(6 * 7)).map { |n|
- n *= 1.0 / 6
+ @colors = (6 * 7).times.map { |n|
+ n *= 1.0 / 3
@@ -120,6 +119,2 @@
- g = (3 * Math.sin(n + 2 * PI_3) + 3).to_i
- b = (3 * Math.sin(n + 4 * PI_3) + 3).to_i
-
- # Then we take rgb and encode them in a single number using base 6.
- # For some mysterious reason, we add 16... to clear the bottom 4 bits?
- # Yes... they're ugly.
+ g = (3 * Math.sin(n + 4 * PI_3) + 3).to_i
+ b = (3 * Math.sin(n + 2 * PI_3) + 3).to_i
@@ -126,0 +122,2 @@
+ # Then we take rgb and encode them in a single number using
+ # base 6, shifted by 16 for the base 16 ansi colors.
@@ -128 +125 @@
- }
+ }.rotate(4) # puts "red" first
lib/minitest/test.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/lib/minitest/test.rb 2024-05-16 02:40:24.360036247 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/lib/minitest/test.rb 2024-05-16 02:40:24.368036223 +0000
@@ -55,3 +55,4 @@
- # Call this at the top of your tests when you want to run your
- # tests in parallel. In doing so, you're admitting that you rule
- # and your tests are awesome.
+ # Call this at the top of your tests (inside the +Minitest::Test+
+ # subclass or +describe+ block) when you want to run your tests in
+ # parallel. In doing so, you're admitting that you rule and your
+ # tests are awesome.
lib/minitest/test_task.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/lib/minitest/test_task.rb 2024-05-16 02:40:24.360036247 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/lib/minitest/test_task.rb 2024-05-16 02:40:24.368036223 +0000
@@ -117 +117 @@
- self.verbose = Rake.application.options.trace
+ self.verbose = Rake.application.options.trace || Rake.verbose == true
test/minitest/metametameta.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/test/minitest/metametameta.rb 2024-05-16 02:40:24.364036235 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/test/minitest/metametameta.rb 2024-05-16 02:40:24.368036223 +0000
@@ -28 +27,0 @@
-end
@@ -29,0 +29,12 @@
+ def error_on_warn?
+ defined?(Minitest::ErrorOnWarning)
+ end
+
+ def assert_deprecation re = /DEPRECATED/
+ assert_output "", re do
+ yield
+ end
+ rescue Minitest::UnexpectedWarning => e # raised if -Werror was used
+ assert_match re, e.message
+ end
+end
@@ -59 +70 @@
- @output = StringIO.new("".encode('UTF-8'))
+ @output = StringIO.new("".encode(Encoding::UTF_8))
@@ -113 +124 @@
- output.gsub!(/^(\s+)(?:[A-Za-z]:)?[^:]+:\d+:in/, '\1FILE:LINE:in')
+ output.gsub!(/^(\s+)(?:[A-Za-z]:)?[^:]+:\d+:in [`']/, '\1FILE:LINE:in \'')
@@ -115,2 +126,2 @@
- output.gsub!(/\[([^\]:]+):\d+\]/) { "[#{file[$1]}:LINE]" }
- output.gsub!(/^(\s+)([^:]+):\d+:in/) { "#{$1}#{file[$2]}:LINE:in" }
+ output.gsub!(/\[([^\]:]+):\d+\]/) { "[#{file[$1]}:LINE]" }
+ output.gsub!(/^(\s+)([^:]+):\d+:in [`']/) { "#{$1}#{file[$2]}:LINE:in '" }
@@ -117,0 +129,3 @@
+
+ output.gsub!(/in [`']block in (?:([^']+)[#.])?/, "in 'block in")
+ output.gsub!(/in [`'](?:([^']+)[#.])?/, "in '")
test/minitest/test_minitest_assertions.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/test/minitest/test_minitest_assertions.rb 2024-05-16 02:40:24.364036235 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/test/minitest/test_minitest_assertions.rb 2024-05-16 02:40:24.368036223 +0000
@@ -3,0 +4 @@
+require_relative "metametameta"
@@ -36 +36,0 @@
- # include Minitest::Reportable # TODO: why do I really need this?
@@ -61,9 +60,0 @@
- def assert_deprecated name
- dep = /DEPRECATED: #{name}. From #{__FILE__}:\d+(?::.*)?/
- dep = "" if $-w.nil?
-
- assert_output nil, dep do
- yield
- end
- end
-
@@ -304 +295 @@
- assert_output "", err_re do
+ assert_deprecation err_re do
@@ -382 +373 @@
- x = "bad-utf8-\xF1.txt".force_encoding "ASCII"
+ x = "bad-utf8-\xF1.txt".dup.force_encoding Encoding::ASCII
@@ -765 +756 @@
- FILE:LINE:in \`block in test_assert_raises_default_triggered\'
+ FILE:LINE:in \'block in test_assert_raises_default_triggered\'
@@ -770,0 +762 @@
+ actual.gsub!(/[`']block in (?:TestMinitestAssertions#)?/, "'block in ")
@@ -844 +836 @@
- FILE:LINE:in \`block in test_assert_raises_subclass_triggered\'
+ FILE:LINE:in \'block in test_assert_raises_subclass_triggered\'
@@ -849,0 +842 @@
+ actual.gsub!(/[`']block in (?:TestMinitestAssertions#)?/, "'block in ")
@@ -866 +859 @@
- FILE:LINE:in \`block in test_assert_raises_triggered_different\'
+ FILE:LINE:in \'block in test_assert_raises_triggered_different\'
@@ -871,0 +865 @@
+ actual.gsub!(/[`']block in (?:TestMinitestAssertions#)?/, "'block in ")
@@ -889 +883 @@
- FILE:LINE:in \`block in test_assert_raises_triggered_different_msg\'
+ FILE:LINE:in \'block in test_assert_raises_triggered_different_msg\'
@@ -894,0 +889 @@
+ actual.gsub!(/[`']block in (?:TestMinitestAssertions#)?/, "'block in ")
@@ -974 +969,2 @@
- assert_deprecated :assert_send do
+ @assertion_count = 0 if error_on_warn?
+ assert_deprecation(/DEPRECATED: assert_send/) do
@@ -980,2 +976,3 @@
- assert_deprecated :assert_send do
- assert_triggered "Expected 1.>(*[2]) to return true." do
+ if error_on_warn? then
+ @assertion_count = 0
+ assert_deprecation(/DEPRECATED: assert_send/) do
@@ -983,0 +981,6 @@
+ else
+ assert_triggered "Expected 1.>(*[2]) to return true." do
+ assert_deprecation(/DEPRECATED: assert_send/) do
+ @tc.assert_send [1, :>, 2]
+ end
+ end
@@ -1501 +1504 @@
- assert_output "", /Stale skip_until \"not yet\" at .*?:\d+$/ do
+ assert_deprecation(/Stale skip_until \"not yet\" at .*?:\d+$/) do
@@ -1645 +1648 @@
- str = "\666".force_encoding Encoding::UTF_8
+ str = "\666".dup.force_encoding Encoding::UTF_8
@@ -1652 +1655 @@
- str = "\666A\\n\nB".force_encoding Encoding::UTF_8
+ str = "\666A\\n\nB".dup.force_encoding Encoding::UTF_8
@@ -1699 +1702 @@
- str = "\666".force_encoding Encoding::UTF_8
+ str = "\666".dup.force_encoding Encoding::UTF_8
test/minitest/test_minitest_mock.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/test/minitest/test_minitest_mock.rb 2024-05-16 02:40:24.364036235 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/test/minitest/test_minitest_mock.rb 2024-05-16 02:40:24.368036223 +0000
@@ -426 +426 @@
- assert_output nil, /Using MT_KWARGS_HAC. yet passing kwargs/ do
+ assert_deprecation(/Using MT_KWARGS_HAC. yet passing kwargs/) do
@@ -429,0 +430,2 @@
+ skip "-Werror" if error_on_warn? # mock above raised, so this is dead
+
@@ -689 +691 @@
- obj = "foo"
+ obj = +"foo"
@@ -731 +733 @@
- /undefined method `nope_nope_nope' for( class)? `#{self.class}::Time'/
+ /undefined method [`']nope_nope_nope' for( class)? [`']#{self.class}::Time'/
@@ -819 +821 @@
- def call
+ def call(&_) # to ignore unused block
@@ -959 +961 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
@@ -974 +976 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
@@ -987 +989 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
@@ -1002 +1004 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
@@ -1017 +1019 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
@@ -1067 +1069 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
@@ -1086 +1088 @@
- exp = /undefined method `write' for nil/
+ exp = /undefined method [`']write' for nil/
@@ -1095 +1097 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
@@ -1113 +1115 @@
- io = StringIO.new "", "w"
+ io = StringIO.new(+"", "w")
test/minitest/test_minitest_reporter.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/test/minitest/test_minitest_reporter.rb 2024-05-16 02:40:24.364036235 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/test/minitest/test_minitest_reporter.rb 2024-05-16 02:40:24.368036223 +0000
@@ -34 +34 @@
- self.io = StringIO.new("")
+ self.io = StringIO.new(+"")
@@ -327,2 +327,2 @@
- FILE:LINE:in `error_test'
- FILE:LINE:in `test_report_error'
+ FILE:LINE:in 'error_test'
+ FILE:LINE:in 'test_report_error'
@@ -400 +400 @@
- ["foo.rb:123:in `foo'"]
+ ["foo.rb:123:in 'foo'"]
@@ -416,9 +416,9 @@
- /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/assertions.rb:183:in `assert'
- example_test.rb:9:in `assert_false'
- /Users/user/.gem/ruby/3.2.2/gems/sorbet-runtime-0.5.11068/lib/types/private/methods/call_validation.rb:256:in `bind_call'
- /Users/user/.gem/ruby/3.2.2/gems/sorbet-runtime-0.5.11068/lib/types/private/methods/call_validation.rb:256:in `validate_call'
- /Users/user/.gem/ruby/3.2.2/gems/sorbet-runtime-0.5.11068/lib/types/private/methods/_methods.rb:275:in `block in _on_method_added'
- example_test.rb:25:in `test_something'
- /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/test.rb:94:in `block (3 levels) in run'
- /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/test.rb:191:in `capture_exceptions'
- /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/test.rb:89:in `block (2 levels) in run'
+ /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/assertions.rb:183:in 'assert'
+ example_test.rb:9:in 'assert_false'
+ /Users/user/.gem/ruby/3.2.2/gems/sorbet-runtime-0.5.11068/lib/types/private/methods/call_validation.rb:256:in 'bind_call'
+ /Users/user/.gem/ruby/3.2.2/gems/sorbet-runtime-0.5.11068/lib/types/private/methods/call_validation.rb:256:in 'validate_call'
+ /Users/user/.gem/ruby/3.2.2/gems/sorbet-runtime-0.5.11068/lib/types/private/methods/_methods.rb:275:in 'block in _on_method_added'
+ example_test.rb:25:in 'test_something'
+ /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/test.rb:94:in 'block (3 levels) in run'
+ /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/test.rb:191:in 'capture_exceptions'
+ /Users/user/.gem/ruby/3.2.2/gems/minitest-5.20.0/lib/minitest/test.rb:89:in 'block (2 levels) in run'
test/minitest/test_minitest_spec.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/test/minitest/test_minitest_spec.rb 2024-05-16 02:40:24.364036235 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/test/minitest/test_minitest_spec.rb 2024-05-16 02:40:24.368036223 +0000
@@ -287 +287,4 @@
- @assertion_count += 1 # extra test
+ @assertion_count = 3
+ @assertion_count += 2 unless error_on_warn? # 2 extra assertions
+
+ exp = /DEPRECATED: Use assert_nil if expecting nil from .* This will fail in Minitest 6./
@@ -289 +292 @@
- out, err = capture_io do
+ assert_deprecation exp do
@@ -292,7 +294,0 @@
-
- exp = "DEPRECATED: Use assert_nil if expecting nil from #{__FILE__}:#{__LINE__-3}. " \
- "This will fail in Minitest 6.\n"
- exp = "" if $-w.nil?
-
- assert_empty out
- assert_equal exp, err
@@ -579 +575,2 @@
- assert_raises RuntimeError do
+
+ assert_raises RuntimeError, Minitest::UnexpectedWarning do
@@ -589 +586 @@
- @assertion_count += 1
+ @assertion_count += 2 # assert_match is compound
@@ -591 +588 @@
- e = assert_raises RuntimeError do
+ e = assert_raises RuntimeError, Minitest::UnexpectedWarning do
@@ -601 +598,4 @@
- assert_equal "Calling #must_equal outside of test.", e.message
+ exp = "Calling #must_equal outside of test."
+ exp = "DEPRECATED: global use of must_equal from" if error_on_warn?
+
+ assert_match exp, e.message
@@ -607 +607,2 @@
- @assertion_count += 3
+ @assertion_count += 1
+ @assertion_count += 2 unless error_on_warn?
@@ -611 +612 @@
- assert_output "", exp do
+ assert_deprecation exp do
@@ -621 +622,2 @@
- @assertion_count += 3
+ @assertion_count += 1
+ @assertion_count += 2 unless error_on_warn?
@@ -626 +628 @@
- assert_output "", exp do
+ assert_deprecation exp do
test/minitest/test_minitest_test.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/test/minitest/test_minitest_test.rb 2024-05-16 02:40:24.364036235 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/test/minitest/test_minitest_test.rb 2024-05-16 02:40:24.368036223 +0000
@@ -31,4 +31,4 @@
- BT_MIDDLE = ["#{MINITEST_BASE_DIR}/test.rb:161:in `each'",
- "#{MINITEST_BASE_DIR}/test.rb:158:in `each'",
- "#{MINITEST_BASE_DIR}/test.rb:139:in `run'",
- "#{MINITEST_BASE_DIR}/test.rb:106:in `run'"]
+ BT_MIDDLE = ["#{MINITEST_BASE_DIR}/test.rb:161:in 'each'",
+ "#{MINITEST_BASE_DIR}/test.rb:158:in 'each'",
+ "#{MINITEST_BASE_DIR}/test.rb:139:in 'run'",
+ "#{MINITEST_BASE_DIR}/test.rb:106:in 'run'"]
@@ -39,3 +39,3 @@
- bt = (["lib/autotest.rb:571:in `add_exception'",
- "test/test_autotest.rb:62:in `test_add_exception'",
- "#{MINITEST_BASE_DIR}/test.rb:165:in `__send__'"] +
+ bt = (["lib/autotest.rb:571:in 'add_exception'",
+ "test/test_autotest.rb:62:in 'test_add_exception'",
+ "#{MINITEST_BASE_DIR}/test.rb:165:in '__send__'"] +
@@ -47,2 +47,2 @@
- ex = ["lib/autotest.rb:571:in `add_exception'",
- "test/test_autotest.rb:62:in `test_add_exception'"]
+ ex = ["lib/autotest.rb:571:in 'add_exception'",
+ "test/test_autotest.rb:62:in 'test_add_exception'"]
@@ -59 +59 @@
- bt = (["#{MINITEST_BASE_DIR}/test.rb:165:in `__send__'"] +
+ bt = (["#{MINITEST_BASE_DIR}/test.rb:165:in '__send__'"] +
@@ -68 +68 @@
- bt = (["#{MINITEST_BASE_DIR}/test.rb:165:in `__send__'"] +
+ bt = (["#{MINITEST_BASE_DIR}/test.rb:165:in '__send__'"] +
@@ -97 +97 @@
- fail 'ЁЁЁ'.force_encoding('ASCII-8BIT')
+ fail 'ЁЁЁ'.dup.force_encoding(Encoding::BINARY)
@@ -114 +114 @@
- FILE:LINE:in `test_this_is_non_ascii_failure_message'
+ FILE:LINE:in 'test_this_is_non_ascii_failure_message'
@@ -266 +266 @@
- FILE:LINE:in \`test_error\'
+ FILE:LINE:in \'test_error\'
@@ -294 +294 @@
- FILE:LINE:in \`teardown\'
+ FILE:LINE:in \'teardown\'
@@ -1129 +1129 @@
- assert_output "", /DEPRECATED/ do
+ assert_deprecation do
@@ -1132 +1132 @@
- assert_output "", /DEPRECATED/ do
+ assert_deprecation do
@@ -1138 +1138 @@
- assert_output "", /DEPRECATED/ do
+ assert_deprecation do
@@ -1141 +1141 @@
- assert_output "", /DEPRECATED/ do
+ assert_deprecation do
@@ -1264 +1264 @@
- FILE:LINE:in `test_method'
+ FILE:LINE:in 'test_method'
@@ -1269 +1269 @@
- FILE:LINE:in `teardown'
+ FILE:LINE:in 'teardown'
test/minitest/test_minitest_test_task.rb
--- /tmp/d20240516-1904-ipsw6j/minitest-5.22.2/test/minitest/test_minitest_test_task.rb 2024-05-16 02:40:24.364036235 +0000
+++ /tmp/d20240516-1904-ipsw6j/minitest-5.23.0/test/minitest/test_minitest_test_task.rb 2024-05-16 02:40:24.368036223 +0000
@@ -28,0 +29 @@
+ .sub(/ -- .+/, " -- ")
@@ -44,0 +46 @@
+ .sub(/ -- .+/, " -- ") |
Bumps [minitest](https://github.com/minitest/minitest) from 5.22.2 to 5.23.0. - [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc) - [Commits](minitest/minitest@v5.22.2...v5.23.0) --- updated-dependencies: - dependency-name: minitest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/bundler/minitest-5.23.0
branch
from
81228bd
to
2e61313
Compare
|
Superseded by #632. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps minitest from 5.22.2 to 5.23.0.
Changelog
Sourced from minitest's changelog.
Commits
b04feecBranching minitest to version 5.23.0f0f17b9+ Added -Werror to raise on any warning output. (byroot)609f1adAdded testW0 rake task.d6f62b9Fixed specs task for pattern_match expectation mapping.56f5068OMG... Rake.verbose returns Object.new if unset. Fixed by ruby/rake#567, but ...3f14f2aUpdated versions/EOL for ruby/rails in readmeb2a4b43+ Added minitest/manual_plugins.rb w/ new Minitest.load method. (tenderlove)6a8f348- Make test task verbose using either rake's -v or -t (was just -t).9594e87- Allow empty_run! and reporter to display summary for empty runs. (zzak)ea9caafIgnore unused block. (ko1)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)