Revert typescript to 2.2.0, #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the version that was not adding `Object.defineProperty(exports, "__esModule", { value: true });`
Therefore, resulting in module transpilable to one with unintended default export.
Fixes backward compatibility and #233
- as CommonJS (require) - as import in Webpack - as import in TypeScript with typings code is backported from 3.x alpha (cec3d27)
|
I just pushed one change, which adds tests for few external API use scenarios:
There is one known problem in TypeScript: The test in line is commented out, because it fails since there is no default export inlib/duplex.js.
@tomalec would you care fixing that by adding an actual default export? |
Amended cherry-pick @1de6122774251a9688a354e2d23a09029dbefa65 # Conflicts: # index.d.ts # index.mjs # index.ts # test/spec/webpack/importSpec.build.js
|
Closing in favour of #236 it seems we have to export default anyway, to make TS happy, so we could keep using latest TS version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the version that was not adding
Object.defineProperty(exports, "__esModule", { value: true });Therefore, resulting in module transpilable to one with unintended default export.
Fixes backward compatibility and #233