Resolve incorrect JsonPatchError format for Arrays #221
+2,668
−1,223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsonPatchErrors in applyOperation now reference index Arrays now reference index, operation, and document when throwing a JsonPatchError
|
Thank you @ianvonholt for your submission. We want to accept this. The PR is lacking a test, though. Would you please like to contribute that? |
|
I'm taking over this. |
Test the behaviour introduced in PR Starcounter-Jack#221
|
This is ready for review. |
|
Thank you @alshakero. I had completely forgotten about this. |
warpech
requested changes
Mar 29, 2019
There was a problem hiding this comment.
It all looks good, but I am missing a test for new error message formatting feature. @alshakero could you please add it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonPatchError
See: #220