Skip to content

Commit

Permalink
pin typing-extensions<4.2 to fix st2client install
Browse files Browse the repository at this point in the history
st2client requires importlib-metadata which requires typing-extensions.
But typing-extensions v4.2.0 dropped support for python3.6, so pin it.
  • Loading branch information
cognifloyd committed May 4, 2022
1 parent abb694b commit 9800b94
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ Changed

* Bump black to v22.3.0 - This is used internally to reformat our python code. #5606

* Pin ``typing-extensions<4.2`` (used indirectly by st2client) to maintain python 3.6 support. #5638


3.6.0 - October 29, 2021
------------------------

Expand Down
2 changes: 2 additions & 0 deletions fixed-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ argparse==1.12.2
argcomplete==1.12.2
prettytable==2.1.0
importlib-metadata==3.10.1
# importlib-metadata requires typing-extensions but v4.2.0 requires py3.7+
typing-extension<4.2
# NOTE: sseclient has various issues which sometimes hang the connection for a long time, etc.
sseclient-py==1.7
stevedore==1.30.1
Expand Down
2 changes: 2 additions & 0 deletions st2client/in-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Remember to list implicit packages here, otherwise version won't be fixated!
importlib-metadata
# importlib-metadata requires typing-extensions
typing-extensions
argcomplete
prettytable
pytz
Expand Down

0 comments on commit 9800b94

Please sign in to comment.