Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add a configuration manager as a crate #262

Merged
merged 4 commits into from May 29, 2023

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented May 25, 2023

Issue number and link

Fixes: #220

This pull request also bumps up minimal supported Rust version to 1.65 because of https://github.com/time-rs/time/releases/tag/v0.3.21.

Describe your changes

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 87.27% and project coverage change: -0.07 ⚠️

Comparison is base (378893c) 84.77% compared to head (830b7a5) 84.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   84.77%   84.70%   -0.07%     
==========================================
  Files         215      215              
  Lines       12692    12687       -5     
==========================================
- Hits        10760    10747      -13     
- Misses       1932     1940       +8     
Impacted Files Coverage Δ
...rc/stream_engine/autonomous_executor/task_graph.rs 94.70% <ø> (-0.10%) ⬇️
...engine/autonomous_executor/test_support/factory.rs 75.00% <0.00%> (ø)
springql-config/src/lib.rs 85.71% <85.71%> (ø)
springql-core/src/pipeline/test_support/fixture.rs 82.12% <100.00%> (-0.20%) ⬇️
...onomous_executor/task/sink_task/sink_writer/net.rs 86.45% <100.00%> (ø)
...cutor/task/source_task/source_reader/net_client.rs 89.28% <100.00%> (-0.13%) ⬇️
...cutor/task/source_task/source_reader/net_server.rs 95.79% <100.00%> (-0.04%) ⬇️
springql/tests/e2e_high_level_rs.rs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

fix clippy warnings
@TaKO8Ki TaKO8Ki changed the title refactor: Add config as a crate refactor: Add a configuration manager as a crate May 25, 2023
@laysakura
Copy link
Contributor

Thanks 🎉

@laysakura laysakura merged commit af6d826 into main May 29, 2023
16 checks passed
@laysakura laysakura deleted the add-config-as-a-crate branch May 29, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration deserialize feature not need in core
3 participants