Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source tcp listener address configurable #260

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AntonOellerer
Copy link
Contributor

@AntonOellerer AntonOellerer commented Mar 15, 2023

To allow listening on different interfaces for incoming connections, the tcp listener address is made configurable.
Additionally, it is set to "0.0.0.0" such that the source server reader listens on all interfaces per default.

Issue number and link

Fixes: #259

Describe your changes

Makes source tcp listener address configurable, sets it to "0.0.0.0" (all interfaces) per default

Checklist before requesting a review

I already tested it locally, but did not write an automated test yet.
I will add a test and documentation updated tomorrow, I just wanted to submit it for review today.

To allow listening on different interfaces for incoming connections, the
tcp listener address is made configurable.
Additionally, it is set to "0.0.0.0" such that the source server reader
listens on all interfaces per default.
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: +0.12 🎉

Comparison is base (df23792) 84.58% compared to head (a43941b) 84.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   84.58%   84.71%   +0.12%     
==========================================
  Files         215      215              
  Lines       12692    12695       +3     
==========================================
+ Hits        10736    10754      +18     
+ Misses       1956     1941      -15     
Impacted Files Coverage Δ
...cutor/task/source_task/source_reader/net_server.rs 93.49% <20.00%> (-2.34%) ⬇️
springql-core/src/api/spring_config.rs 85.29% <100.00%> (ø)
.../stream_engine/autonomous_executor/repositories.rs 95.23% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCP server source only listens on "127.0.0.1"
2 participants