fix: Yield after submitting nc command #257
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, it was possible that the order of messages submitted by example scripts to the pipeline was mixed up if all of the `nc` commands were submitted in one CPU processing slot. This caused the affected examples to come to wrong results. To fix this, the processing thread is sent to sleep after each command. By doing this, the thread yields it processing time, and the `nc` command gets submitted. Fixes SpringQL#256
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 84.58% 84.65% +0.07%
==========================================
Files 215 215
Lines 12692 12692
==========================================
+ Hits 10736 10745 +9
+ Misses 1956 1947 -9 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
|
|
@AntonOellerer Thank you for having interest to this project! Could you sign the CLA from the CLAassistant comment? |
laysakura
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, it was possible that the order of messages submitted by example scripts to the pipeline was mixed up if all of the
nccommands were submitted in one CPU processing slot. This caused the affected examples to come to wrong results.To fix this, the processing thread is sent to sleep after each command. By doing this, the thread yields it processing time, and the
nccommand gets submitted.Issue number and link
Fixes #256
Describe your changes
Checklist before requesting a review
## [Unreleased]section inCHANGELOG.mdfollowing keep a changelog syntax (bugfix/feature)