Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fix): Fix release workflow #226

Merged
merged 13 commits into from Jul 11, 2022
Merged

ci(fix): Fix release workflow #226

merged 13 commits into from Jul 11, 2022

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jul 11, 2022

Issue number and link

Fixes: #66

Describe your changes

add release workflow.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@kazuk kazuk requested a review from laysakura July 11, 2022 21:20
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #226 (65b04f8) into main (c4a8fef) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   83.92%   84.00%   +0.07%     
==========================================
  Files         218      218              
  Lines       12743    12743              
==========================================
+ Hits        10695    10705      +10     
+ Misses       2048     2038      -10     
Impacted Files Coverage Δ
...ql_processor/sql_parser/pest_parser_impl/helper.rs 92.85% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a8fef...65b04f8. Read the comment docs.

@laysakura laysakura changed the title Fix release workflow ci(fix): Fix release workflow Jul 11, 2022
@laysakura
Copy link
Contributor

I follow the Semantic Pull Requests rules (bugfix/feature)

I changed the PR title.

Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added one comment.

.github/workflows/scripts/keep-a-changelog.bash Outdated Show resolved Hide resolved
Co-authored-by: Sho Nakatani <lay.sakura@gmail.com>
@laysakura laysakura self-requested a review July 11, 2022 23:23
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@laysakura laysakura merged commit 2ee270c into main Jul 11, 2022
@laysakura laysakura deleted the fix_release_workflow branch July 11, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: more automated release process
2 participants