New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: release script #215
ci: release script #215
Conversation
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 84.85% 83.92% -0.93%
==========================================
Files 215 218 +3
Lines 12545 12743 +198
==========================================
+ Hits 10645 10695 +50
- Misses 1900 2048 +148
Continue to review full report at Codecov.
|
if [ "$line" == "## [Unreleased]" ]; then | ||
# insert line after ## [Unleleased] | ||
echo # output blank line | ||
echo "## [${NEW_VERSION}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From v0.14.0, we started to add the release date here.
https://github.com/SpringQL/SpringQL/blob/main/CHANGELOG.md#v0140---2022-06-24
Could you add the date automatically from system clock? (either UTC or JST would be OK)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry. How about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do it with minor change.
I want tests whole release workflow first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. You can merge this to try the workflow execution if you will do something for the comment later.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge it for checking the workflow but I added a comment.
if [ "$line" == "## [Unreleased]" ]; then | ||
# insert line after ## [Unleleased] | ||
echo # output blank line | ||
echo "## [${NEW_VERSION}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry. How about this?
Issue number and link
Relates: #66
Describe your changes
currently disable for any update to git and crates.io , so we need test for flow is collect.
Checklist before requesting a review
## [Unreleased]
section inCHANGELOG.md
following keep a changelog syntax (bugfix/feature)