Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: de-couple JSON and SourceRow #190

Merged
merged 4 commits into from
Jun 10, 2022
Merged

refactor: de-couple JSON and SourceRow #190

merged 4 commits into from
Jun 10, 2022

Conversation

laysakura
Copy link
Contributor

Issue number and link

Refs: #189

SourceRow should be independent of JSON format.

Describe your changes

  • Make SourceRow into enum
  • Add JsonSourceRow
  • Use new SourceRow in SourceReader

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@laysakura laysakura marked this pull request as ready for review June 10, 2022 09:11
@laysakura laysakura merged commit 0bd6733 into main Jun 10, 2022
@laysakura laysakura deleted the refactor/remove-SourceRow branch June 10, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@laysakura