Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re orgnize public API #169

Merged
merged 10 commits into from
Jun 8, 2022
Merged

feat: re orgnize public API #169

merged 10 commits into from
Jun 8, 2022

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented May 31, 2022 •
edited

Issue number and link

Fixes: #158

Describe your changes

  • mod api into public
  • refactor use
    • not to use super self, shoud be use crate
    • use ordinal std external crates, crate::
  • file level ordinal , mod definition to use definition
  • re-export high_level_rs members from api
  • re-export low_level_rs members from api
  • move low_level_rs::engine_mutex::EngineMutex to stream_engine
  • move low_level_rs members to pipeline
  • rename SpringPipelineHL to SpringPipeline
  • rename SpringRowHL to SpringRow

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited

Codecov Report

Merging #169 (49591a6) into main (308bc5f) will decrease coverage by 0.41%.
The diff coverage is 84.42%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   87.92%   87.50%   -0.42%     
==========================================
  Files         204      201       -3     
  Lines       12695    12273     -422     
==========================================
- Hits        11162    10740     -422     
  Misses       1533     1533
Impacted Files Coverage Δ
foreign-service/src/sink.rs 91.66% <ø> (ø)
foreign-service/src/source.rs 94.73% <ø> (ø)
foreign-service/src/source/source_input.rs 61.53% <ø> (ø)
...gn-service/src/source/source_input/timed_stream.rs 0.00% <ø> (ø)
...rc/source/source_input/timed_stream/file_parser.rs 0.00% <ø> (ø)
springql-core/src/api/error.rs 0.00% <ø> (ø)
springql-core/src/expr_resolver.rs 88.67% <ø> (ø)
springql-core/src/expression.rs 74.25% <ø> (ø)
springql-core/src/expression/boolean_expression.rs 100.00% <ø> (ø)
springql-core/src/expression/function_call.rs 100.00% <ø> (ø)
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308bc5f...49591a6. Read the comment docs.

@kazuk kazuk mentioned this pull request Jun 4, 2022
Merged
kazuk added 7 commits June 7, 2022 07:16
@kazuk
refactor api mod public
90b8cac
@kazuk
re orginize use
0e6d51e
@kazuk
hide mod high_level_rs
b5d34ab 
 SpringPipelineHL and SpringRowHL was moved from
 `crate::api::high_level_rs::` to `crate::api::`
@kazuk
hide mod low_level_rs
f69edfd 
remove test for low level.
remove dead code.
@kazuk
rewrite test_spring_open_twice
7e2fbdd
@kazuk
rename SpringPipelineHL/SpringRowHL
e16314f 
move low_level_rs::SpringPipeline to pipeline
@kazuk
fix document
25a8a50
@kazuk kazuk requested a review from laysakura June 6, 2022 22:49
@kazuk kazuk changed the title Refactor_api_2 re orgnize public API Jun 6, 2022
@kazuk kazuk marked this pull request as ready for review June 6, 2022 22:52
laysakura
laysakura requested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your diligent work!

Just one thing: I would like to totally remove "high-level" and "low-level" category from APIs and documentations.

I guess we can remove low_level mod in springql-core crate in this PR.

springql-core/src/api/low_level_rs/spring_config.rs Outdated Show resolved Hide resolved
springql-core/src/api/low_level_rs/engine_mutex.rs Outdated Show resolved Hide resolved
springql-core/src/api/low_level_rs.rs Outdated Show resolved Hide resolved
@laysakura laysakura changed the title re orgnize public API feat: re orgnize public API Jun 7, 2022
laysakura added a commit to SpringQL/SpringQL.github.io that referenced this pull request Jun 7, 2022
@laysakura
docs: change non-code texts to follow API changes in SpringQL/SpringQ…
ab246e1 
…L#169
@kazuk
remove mod high_level_rs/low_level_rs
49591a6 
move high_level_rs members to api
move low_level_rs::spring_config mod to api
remove fn spring_config_toml
laysakura
laysakura approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@laysakura laysakura merged commit fe64b70 into main Jun 8, 2022
@laysakura laysakura deleted the refactor_api_2 branch June 8, 2022 00:56
This was referenced Jun 9, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laysakura laysakura laysakura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move apis from high_level_rs/low_level_rs to crate root/inner module
2 participants
@kazuk @laysakura