Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deadlink job #167

Closed
wants to merge 2 commits into from
Closed

fix: deadlink job #167

wants to merge 2 commits into from

Conversation

laysakura
Copy link
Contributor

Issue number and link

Fixes: #166

Describe your changes

Stop exporting pub structs/traits in top-level to prevent pest_derive to implement its traits.

See #166 why this fix works.

This is a breaking change since it changes import path of pub types.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@laysakura laysakura requested a review from kazuk May 31, 2022 01:40
@laysakura
Copy link
Contributor Author

lcov job started to fail: https://github.com/SpringQL/SpringQL/runs/6663137648?check_suite_focus=true

It seems to run rustdoc ... --test ... to gather coverage and fail in Address already in use.

This might be due to #156, which add a test case to use the same port as examples/doc_app1.rs.

@laysakura
Copy link
Contributor Author

Close this PR.

  • SpringEventDuration, SpringTimestamp, SpringValue become private since crate::api is private mod.
  • After making crate::api public, SpringEventDuration again reported deadlink.

@laysakura laysakura closed this May 31, 2022
@laysakura laysakura deleted the ci/fix-deadlink-job branch May 31, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deadlink check fails
1 participant