Merge pull request #239 from SpringQL/fix_clippy_lint

refactor: fix clippy lint
SpringQL · Aug 31, 2022 · 92abd52 · 92abd52
2 parents e74ce51 + 0357b1e
commit 92abd52
Show file tree

Hide file tree

Showing 12 changed files with 23 additions and 23 deletions.
diff --git a/springql-core/src/expression/boolean_expression.rs b/springql-core/src/expression/boolean_expression.rs
@@ -12,7 +12,7 @@ use crate::expression::ValueExprType;
 
 /// Boolean expression.
 #[allow(clippy::enum_variant_names)]
-#[derive(Clone, PartialEq, Hash, Debug)]
+#[derive(Clone, PartialEq, Eq, Hash, Debug)]
 pub enum BinaryExpr<E>
 where
     E: ValueExprType,

diff --git a/springql-core/src/expression/boolean_expression/comparison_function.rs b/springql-core/src/expression/boolean_expression/comparison_function.rs
@@ -3,7 +3,7 @@
 use crate::expression::ValueExprType;
 
 /// Comparison function and its operands
-#[derive(Clone, PartialEq, Hash, Debug)]
+#[derive(Clone, PartialEq, Eq, Hash, Debug)]
 pub enum ComparisonFunction<E>
 where
     E: ValueExprType,

diff --git a/springql-core/src/expression/boolean_expression/logical_function.rs b/springql-core/src/expression/boolean_expression/logical_function.rs
@@ -3,7 +3,7 @@
 use crate::expression::ValueExprType;
 
 /// AND, OR, NOT
-#[derive(Clone, PartialEq, Hash, Debug)]
+#[derive(Clone, PartialEq, Eq, Hash, Debug)]
 pub enum LogicalFunction<E>
 where
     E: ValueExprType,

diff --git a/springql-core/src/expression/boolean_expression/numerical_function.rs b/springql-core/src/expression/boolean_expression/numerical_function.rs
@@ -2,7 +2,7 @@
 
 use crate::expression::ValueExprType;
 
-#[derive(Clone, PartialEq, Hash, Debug)]
+#[derive(Clone, PartialEq, Eq, Hash, Debug)]
 pub enum NumericalFunction<E>
 where
     E: ValueExprType,

diff --git a/springql-core/src/expression/function_call.rs b/springql-core/src/expression/function_call.rs
@@ -2,7 +2,7 @@
 
 use crate::expression::ValueExprType;
 
-#[derive(Clone, PartialEq, Hash, Debug)]
+#[derive(Clone, PartialEq, Eq, Hash, Debug)]
 pub enum FunctionCall<E>
 where
     E: ValueExprType,

diff --git a/springql-core/src/pipeline/pump_model/window_operation_parameter.rs b/springql-core/src/pipeline/pump_model/window_operation_parameter.rs
@@ -7,7 +7,7 @@ pub use aggregate::{AggregateFunctionParameter, AggregateParameter, GroupByLabel
 pub use join_parameter::{JoinParameter, JoinType};
 
 /// Window operation parameters
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub enum WindowOperationParameter {
     Aggregate(AggregateParameter),
     Join(JoinParameter),

diff --git a/springql-core/src/pipeline/pump_model/window_operation_parameter/aggregate.rs b/springql-core/src/pipeline/pump_model/window_operation_parameter/aggregate.rs
@@ -3,7 +3,7 @@
 use crate::expr_resolver::{AggrExprLabel, ValueExprLabel};
 
 /// [GROUP BY c1, c2, c3...]
-#[derive(Clone, PartialEq, Debug, Default, new)]
+#[derive(Clone, PartialEq, Eq, Debug, Default, new)]
 pub struct GroupByLabels(
     /// Empty when GROUP BY clause is not supplied.
     Vec<ValueExprLabel>,
@@ -22,7 +22,7 @@ impl GroupByLabels {
 ///   [GROUP BY group_by]
 ///   SLIDING WINDOW ...;
 /// ```
-#[derive(Clone, PartialEq, Debug, new)]
+#[derive(Clone, PartialEq, Eq, Debug, new)]
 pub struct AggregateParameter {
     // TODO multiple aggr_expr
     pub aggr_func: AggregateFunctionParameter,

diff --git a/springql-core/src/pipeline/pump_model/window_operation_parameter/join_parameter.rs b/springql-core/src/pipeline/pump_model/window_operation_parameter/join_parameter.rs
@@ -11,7 +11,7 @@ use crate::{expr_resolver::ValueExprLabel, pipeline::field::ColumnReference};
 ///   ON s.c1 = t.c1
 ///   SLIDING WINDOW ...;
 /// ```
-#[derive(Clone, PartialEq, Debug, new)]
+#[derive(Clone, PartialEq, Eq, Debug, new)]
 pub struct JoinParameter {
     pub join_type: JoinType,
 

diff --git a/springql-core/src/sql_processor/sql_parser/syntax.rs b/springql-core/src/sql_processor/sql_parser/syntax.rs
@@ -53,7 +53,7 @@ pub enum FromItemSyntax {
     },
 }
 
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub struct SubFromItemSyntax {
     pub stream_name: StreamName,
     pub alias: Option<CorrelationAlias>,

diff --git a/...utonomous_executor/performance_monitor_worker/web_console_reporter/web_console_request.rs b/...utonomous_executor/performance_monitor_worker/web_console_reporter/web_console_request.rs
@@ -18,18 +18,18 @@ impl WebConsoleRequest {
         let tasks = metrics
             .get_tasks()
             .iter()
-            .map(|(id, metrics)| TaskRequest::from_metrics(id, &*metrics))
+            .map(|(id, metrics)| TaskRequest::from_metrics(id, metrics))
             .collect();
 
         let queues = metrics
             .get_row_queues()
             .iter()
-            .map(|(id, metrics)| QueueRequest::from_row(id, &*metrics, graph))
+            .map(|(id, metrics)| QueueRequest::from_row(id, metrics, graph))
             .chain(
                 metrics
                     .get_window_queues()
                     .iter()
-                    .map(|(id, metrics)| QueueRequest::from_window(id, &*metrics, graph)),
+                    .map(|(id, metrics)| QueueRequest::from_window(id, metrics, graph)),
             )
             .collect();
 

diff --git a/springql-core/src/stream_engine/command/query_plan/query_plan_operation.rs b/springql-core/src/stream_engine/command/query_plan/query_plan_operation.rs
@@ -5,7 +5,7 @@ use crate::{
     pipeline::{JoinParameter, StreamName, WindowOperationParameter, WindowParameter},
 };
 
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub struct UpperOps {
     pub projection: ProjectionOp,
     pub group_aggr_window: Option<GroupAggregateWindowOp>,
@@ -16,7 +16,7 @@ impl UpperOps {
     }
 }
 
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub struct LowerOps {
     pub join: JoinOp,
 }
@@ -26,30 +26,30 @@ impl LowerOps {
     }
 }
 
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub struct ProjectionOp {
     pub expr_labels: Vec<ExprLabel>,
 }
 
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub struct GroupAggregateWindowOp {
     pub window_param: WindowParameter,
     pub op_param: WindowOperationParameter,
 }
 
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub struct CollectOp {
     pub stream: StreamName,
 }
 
 /// TODO recursive join
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub enum JoinOp {
     Collect(CollectOp),
     JoinWindow(JoinWindowOp),
 }
 
-#[derive(Clone, PartialEq, Debug)]
+#[derive(Clone, PartialEq, Eq, Debug)]
 pub struct JoinWindowOp {
     pub left: CollectOp,
     pub right: CollectOp,

diff --git a/springql/tests/test_support/request_body.rs b/springql/tests/test_support/request_body.rs
@@ -17,7 +17,7 @@ pub struct TaskRequest {
     pub avg_gain_bytes_per_sec: f32,
 }
 
-#[derive(Clone, PartialEq, Debug, Deserialize)]
+#[derive(Clone, PartialEq, Eq, Debug, Deserialize)]
 pub struct QueueRequest {
     pub id: String,
     #[serde(rename = "upstream-task-id")]
@@ -31,15 +31,15 @@ pub struct QueueRequest {
     pub window_queue: Option<WindowQueueRequest>,
 }
 
-#[derive(Clone, PartialEq, Debug, Deserialize)]
+#[derive(Clone, PartialEq, Eq, Debug, Deserialize)]
 pub struct RowQueueRequest {
     #[serde(rename = "num-rows")]
     pub num_rows: u64,
     #[serde(rename = "total-bytes")]
     pub total_bytes: u64,
 }
 
-#[derive(Clone, PartialEq, Debug, Deserialize)]
+#[derive(Clone, PartialEq, Eq, Debug, Deserialize)]
 pub struct WindowQueueRequest {
     #[serde(rename = "num-rows-waiting")]
     pub num_rows_waiting: u64,