Enable PMD static analysis during the build #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
============================================
- Coverage 74.75% 74.74% -0.01%
Complexity 2376 2376
============================================
Files 386 386
Lines 9843 9840 -3
Branches 590 589 -1
============================================
- Hits 7358 7355 -3
Misses 2323 2323
Partials 162 162 |
|
@alexander-yevsyukov PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the PMD code analysis for
basemodules.Some warnings were suppressed and some violations were addressed.
Checkstyle rules aren't enabled with this PR due to the checkstyle/checkstyle#3238, which causes Checkstyle to crash on
LogMessageswith@Nullable ... params.