UX-373 Upgrade styled-components to 5.2 #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference: styled-components/jest-styled-components#297 |
jonambas
changed the title
clean helper function
jonambas
commented
Nov 16, 2020
| import toJson from 'enzyme-to-json'; | ||
| import * as matchers from './matchers' | ||
| import * as matchers from './matchers'; | ||
| import 'jest-styled-components'; |
There was a problem hiding this comment.
Globally importing jest-styled-components instead of in every test - this fixed the "could not resolve SC internals" errors
jonambas
commented
Nov 16, 2020
| @@ -30,6 +30,7 @@ | |||
| "^react-native$": "react-native-web", | |||
| "\\.(css|scss)$": "identity-obj-proxy", | |||
| "@sparkpost/matchbox-icons(.*)": "<rootDir>/packages/matchbox-icons/src", | |||
| "@sparkpost/matchbox(.*)": "<rootDir>/packages/matchbox/src" | |||
| "@sparkpost/matchbox(.*)": "<rootDir>/packages/matchbox/src", | |||
| "^styled-components": "<rootDir>/node_modules/styled-components" | |||
There was a problem hiding this comment.
Turns out we needed to resolve one styled-components module
jonambas
commented
Nov 16, 2020
| shouldForwardProp: (prop, defaultFn) => !arr.includes(prop) && defaultFn(prop), | ||
| ...config, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Here is the helper function
jonambas
added a commit
that referenced
this pull request
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
styled-componentsv5.2jest-styled-componentsv7styled-componentsv5.1.0.jest-styled-componentsin jest's setup file instead of in every test filewrapperswithin arrow function.at(x)in a few places that were detecting multiple DOM nodescleanPropshelper to filter out styling propsHow To Test or Verify
PR Checklist
typelabel