Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(paths): use TypeScript absolute paths #208

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Apr 12, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Chore (anything else), please describe:

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Fixes #267.

@C0ZEN C0ZEN added the enhancement Add a new feature/enhancement label Apr 12, 2020
@C0ZEN C0ZEN added this to the v2.0.0 milestone Apr 12, 2020
@C0ZEN C0ZEN requested a review from vvalembois April 12, 2020 08:40
@C0ZEN C0ZEN self-assigned this Apr 12, 2020
@C0ZEN C0ZEN added this to In progress in Sonia features/issues via automation Apr 12, 2020
@C0ZEN C0ZEN marked this pull request as ready for review April 12, 2020 10:39
@C0ZEN C0ZEN added dependency-fix Need to wait for a dependency fix parcel Related to parcel labels Apr 12, 2020
@C0ZEN
Copy link
Member Author

C0ZEN commented Apr 12, 2020

The feature is all good except for one thing:
Running the production.

Parcel 1 can not handle for now the custom TypeScript paths.
A plugins exists nevertheless there are a lot of compilation errors and anyway, it is not maintained anymore.

It lead to two solutions:

  • Wait for Parcel 2 (an official feature exists for the support)
  • Remove parcel to use something else to build the production

For now, I prefer the first solution since this feature is not a must have.

@C0ZEN C0ZEN added the waiting Manual stale. Should have an explicit reason in the comments. label Apr 12, 2020
@C0ZEN C0ZEN removed the request for review from vvalembois April 12, 2020 10:44
@C0ZEN
Copy link
Member Author

C0ZEN commented Apr 12, 2020

Waiting parcel-bundler/parcel#202

Sonia features/issues automation moved this from In progress to Reviewer approved Apr 12, 2020
@C0ZEN
Copy link
Member Author

C0ZEN commented Apr 12, 2020

@vvalembois no need to review it, the label waiting it set because it is not yet finished.

@C0ZEN C0ZEN linked an issue Apr 25, 2020 that may be closed by this pull request
@C0ZEN C0ZEN changed the title feat(paths): use absolute paths feat(paths): use TypeScript absolute paths Apr 25, 2020
@C0ZEN C0ZEN requested review from vvalembois and removed request for vvalembois May 22, 2020 20:06
@C0ZEN C0ZEN marked this pull request as draft May 22, 2020 20:06
@C0ZEN C0ZEN changed the title feat(paths): use TypeScript absolute paths WIP: feat(paths): use TypeScript absolute paths May 26, 2020
@C0ZEN C0ZEN marked this pull request as ready for review May 26, 2020 18:03
@C0ZEN C0ZEN changed the title WIP: feat(paths): use TypeScript absolute paths feat(paths): use TypeScript absolute paths Jun 26, 2021
@C0ZEN C0ZEN marked this pull request as draft June 26, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-fix Need to wait for a dependency fix enhancement Add a new feature/enhancement parcel Related to parcel waiting Manual stale. Should have an explicit reason in the comments.
Projects
Sonia features/issues
  
Reviewer approved
Development

Successfully merging this pull request may close these issues.

Use TypeScript absolute paths
2 participants