Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency pug to v3.0.1 [security] #1325

Merged
merged 1 commit into from Apr 25, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 3, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pug (source) 3.0.0 -> 3.0.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2021-21353

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to pug@3.0.1 or pug-code-gen@3.0.2 or pug-code-gen@2.0.3, which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: pugjs/pug#3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy


Release Notes

pugjs/pug

v3.0.1

Compare Source

Bug Fixes

  • Sanitise the pretty option (#​3314)

    If a malicious attacker could control the pretty option, it was possible for them to achieve remote code execution on the server rendering the template. All pug users should upgrade as soon as possible, see #​3312 for more details.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot assigned C0ZEN Mar 3, 2021
@renovate renovate bot requested a review from C0ZEN March 3, 2021 05:26
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1325 (bd8e766) into develop (ab658a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1325   +/-   ##
========================================
  Coverage    97.15%   97.15%           
========================================
  Files          324      324           
  Lines         7176     7176           
  Branches       743      743           
========================================
  Hits          6972     6972           
  Misses         204      204           
Flag Coverage Δ
integration 97.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 5 times, most recently from 8ba5020 to 7383a07 Compare April 3, 2021 09:04
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 6 times, most recently from 422bce3 to 872405d Compare April 10, 2021 09:17
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 5 times, most recently from 48d92b0 to 23a59f9 Compare April 18, 2021 13:11
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 3 times, most recently from 4edf4df to 5640dc4 Compare April 25, 2021 08:56
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch from 5640dc4 to bd8e766 Compare April 25, 2021 16:05
@C0ZEN C0ZEN merged commit d472ad0 into develop Apr 25, 2021
@C0ZEN C0ZEN deleted the renovate/npm-pug-vulnerability branch April 25, 2021 16:33
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.92.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Added when a Github/npm release was made label Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Added when a Github/npm release was made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants