Make yes no prompts clearer #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Songmu
added a commit
that referenced
this pull request
Aug 31, 2020
## [v0.4.0](v0.3.0...v0.4.0) (2020-09-01) * Added support for using pipes with GO_PROMPTER_USE_PIPE [#8](#8) ([pyama86](https://github.com/pyama86)) * Make yes no prompts clearer [#9](#9) ([scallister](https://github.com/scallister))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initially using this library I got confused initially because I saw the
YesNofunction's second variable,yes booland thought that meant "what should the yes value evaluate to". That had the opposite effect from what I had intended.This updates the variable to make it a bit more clear what is happening in that second variable.
I also checked that
go teststill passes 馃憤.