This repository has been archived by the owner on Aug 5, 2021. It is now read-only.
SONAR-13155 Upgrade dependencies #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-davis-sonarsource
requested review from
philippe-perrin-sonarsource and
siegfried-ehret-sonarsource
jeremy-davis-sonarsource
force-pushed
the
feature/jay/upgrade-dependencies
branch
from
f65e451
to
e7ac4d0
Compare
| @@ -39,8 +39,8 @@ exports[`should render correctly 1`] = ` | |||
| className="line-chart-grid" | |||
| x1={0} | |||
| x2={30} | |||
| y1={34.666666666666664} | |||
| y2={34.666666666666664} | |||
| y1={34.66666666666667} | |||
There was a problem hiding this comment.
Interesting... 🤔
There was a problem hiding this comment.
My guess is that it's d3/d3-interpolate#73 ?
siegfried-ehret-sonarsource
approved these changes
Mar 18, 2020
|
Kudos, SonarQube Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with SONAR#2615
/!\ SC will have to align some dependency versions for this to work!
Checklist