SonarReportingContext: Add ReportIssue with SecondaryLocation #9298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/SecondaryLocations
branch
from
e200222
to
4c0c436
Compare
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
martin-strecker-sonarsource
requested changes
May 23, 2024
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarReportingContextBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarReportingContextBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Extensions/CompilationExtensions.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SyntaxNodeExtensions.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
pavel-mikula-sonarsource
force-pushed
the
Pavel/SecondaryLocations
branch
from
f5edbf6
to
4bf10b9
Compare
github-actions
bot
assigned martin-strecker-sonarsource and unassigned pavel-mikula-sonarsource
|
|
martin-strecker-sonarsource
approved these changes
May 23, 2024
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned martin-strecker-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #9174
Review per commit shows the logical changes.
The purpose of this PR is to prepare everything that will be needed by all other rules. Migration of other rules (mainly monotounus removals of
DiagnosticDescriptorExtensions.CreateDiagnosticwill be in upcoming PRs)The goals are:
ReportIssuecontract clear aboutSecondaryLocationboundaryToPropertiesdoes not respectSecondaryLocation.Message, but uses additional argument insteadI've changed
params object[]toparams string[]so we don't risk accidentally sending a collection of secondary locations (with a wrong type) to the params value.