Move DescriptorFactory and DiagnosticAnalyzers to namespaces #9294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/Namespace
branch
from
25b6496
to
14afabb
Compare
|
|
sebastien-marichal
approved these changes
May 21, 2024
analyzers/src/SonarAnalyzer.Common/Analyzers/TrackerHotspotDiagnosticAnalyzer.cs
Show resolved
Hide resolved
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this is to move
DescriptorFactoryout ofSonarAnalyzernamespace to a sub-namespace, as global using are finally available in C# and the type doesn't need to be in the root anymore.On the way *DiagnosticAnalyzer were moved to
Analyzersdirectory and namespace CaYCReview per commit is suggested, as there's a file-scoped-namespace update on the way
ToDo: Send mail once done