Create rule S5344: Passwords should not be stored in plain-text or with a fast hashing algorithm (Part 2) #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analyzers/src/SonarAnalyzer.CSharp/Rules/PasswordsShouldBeStoredCorrectly.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.TestFramework/MetadataReferences/NuGetMetadataReference.cs
Show resolved
Hide resolved
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned gregory-paidis-sonarsource
gregory-paidis-sonarsource
changed the title
gregory-paidis-sonarsource
force-pushed
the
greg/implement-S5344-part-2
branch
from
d10a789
to
834a046
Compare
|
@costin-zaharia-sonarsource all of the code smells are magic numbers.
Let me know if you agree and I will take care of them. |
gregory-paidis-sonarsource
force-pushed
the
greg/implement-S5344
branch
2 times, most recently
from
4e8d69a
to
ccd5c9a
Compare
gregory-paidis-sonarsource
force-pushed
the
greg/implement-S5344-part-2
branch
from
834a046
to
f3570ab
Compare
10 tasks
analyzers/its/expected/ManuallyAddedNoncompliantIssues.CS/S5344-NetFramework48.json
Outdated
Show resolved
Hide resolved
gregory-paidis-sonarsource
force-pushed
the
greg/implement-S5344-part-2
branch
from
f3570ab
to
7ce44f7
Compare
analyzers/src/SonarAnalyzer.CSharp/Rules/PasswordsShouldBeStoredCorrectly.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/PasswordsShouldBeStoredCorrectly.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/PasswordsShouldBeStoredCorrectly.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/PasswordsShouldBeStoredCorrectly.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/PasswordsShouldBeStoredCorrectly.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/PasswordsShouldBeStoredCorrectlyTest.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/Rules/PasswordsShouldBeStoredCorrectlyTest.cs
Show resolved
Hide resolved
|
@costin-zaharia-sonarsource Second commit is review from previous PR. |
gregory-paidis-sonarsource
added
the
Sprint: MMF-3716 crypto rules
10 tasks
Comment on lines
+108
to
+109
| x.IterationCount = 1; // Noncompliant {{Use at least 100,000 iterations here.}} | ||
| // ^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
I think a compliant example is missing with setting the IterationCount property to a safe value.
costin-zaharia-sonarsource
approved these changes
May 21, 2024
github-actions
bot
assigned gregory-paidis-sonarsource and unassigned costin-zaharia-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8998
Whatever is checked, is implemented in this PR:
PasswordHasherOptions.IterationCount < 100K (Core)PasswordHasherOptions.CompatibilityMode == IdentityV2 (Core)KeyDerivation.Pbkdf2.iterationCount < 100K (Core)Rfc2898DeriveBytes.Pbkdf2.iterations < 100K (Core)PasswordHasherinstantiated (FRM)Rfc2898DeriveBytes.iterations < 100K (cross-platform)Rfc2898DeriveBytes.hashAlgorithm does not exist (cross-platform)OpenBsdCrypt/BCrypt).Generate.cost < 12 (BouncyCastle)PbeParametersGenerator.Init.iterationCount < 100K (BouncyCastle)SCrypt.Generate N < 2^12, r < 8, or dklen < 32 (BouncyCastle)