Improve S3776: Exclude complexity of JSX short-circuits

SonarSource · Nov 30, 2022 · c234a0c · c234a0c
1 parent 034ecc7
commit c234a0c
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 2 deletions.
diff --git a/src/rules/cognitive-complexity.ts b/src/rules/cognitive-complexity.ts
@@ -113,6 +113,9 @@ const rule: TSESLint.RuleModule<string, (number | 'metric' | 'sonar-runtime')[]>
     /** Stack of enclosing functions */
     const enclosingFunctions: TSESTree.FunctionLike[] = [];
 
+    /** Indicator if inside a JSX expression */
+    let jsx = false;
+
     let secondLevelFunctions: Array<{
       node: TSESTree.FunctionLike;
       parent: TSESTree.Node | undefined;
@@ -153,7 +156,12 @@ const rule: TSESLint.RuleModule<string, (number | 'metric' | 'sonar-runtime')[]>
           });
         }
       },
-
+      'JSXElement,JSXFragment'() {
+        jsx = true;
+      },
+      'JSXElement,JSXFragment:exit'() {
+        jsx = false;
+      },
       IfStatement(node: TSESTree.Node) {
         visitIfStatement(node as TSESTree.IfStatement);
       },
@@ -339,6 +347,10 @@ const rule: TSESLint.RuleModule<string, (number | 'metric' | 'sonar-runtime')[]>
     }
 
     function visitLogicalExpression(logicalExpression: TSESTree.LogicalExpression) {
+      if (jsx) {
+        return;
+      }
+
       if (!consideredLogicalExpressions.has(logicalExpression)) {
         const flattenedLogicalExpressions = flattenLogicalExpression(logicalExpression);
 

diff --git a/tests/rules/cognitive-complexity.test.ts b/tests/rules/cognitive-complexity.test.ts
@@ -22,7 +22,51 @@ import { ruleTester } from '../rule-tester';
 import rule = require('../../src/rules/cognitive-complexity');
 
 ruleTester.run('cognitive-complexity', rule, {
-  valid: [{ code: `function zero_complexity() {}`, options: [0] }],
+  valid: [
+    { code: `function zero_complexity() {}`, options: [0] },
+    {
+      code: `
+      function Component(obj) {
+        return (
+          <span>{ obj.title?.text }</span>
+        );
+      }`,
+      parserOptions: { ecmaFeatures: { jsx: true } },
+      options: [0],
+    },
+    {
+      code: `
+      function Component(obj) {
+        return (
+          <>
+              { obj.isFriendly && <strong>Welcome</strong> }
+          </>
+        );
+      }`,
+      parserOptions: { ecmaFeatures: { jsx: true } },
+      options: [0],
+    },
+    {
+      code: `
+      function Component(obj) {
+        return (
+          <span title={ obj.isFriendly || obj.disclaimer }>Text</span>
+        );
+      }`,
+      parserOptions: { ecmaFeatures: { jsx: true } },
+      options: [0],
+    },
+    {
+      code: `
+      function Component(obj) {
+        return (
+          <button type="button" disabled={ obj.user?.isBot ?? obj.isDemo }>Logout</button>
+        );
+      }`,
+      parserOptions: { ecmaFeatures: { jsx: true } },
+      options: [0],
+    },
+  ],
   invalid: [
     // if
     {