Fix S17647(no-identical-expressions): Consider bigint for 1bit shif…

…ting as valid (#416)
SonarSource · Aug 23, 2023 · 88a748d · 88a748d
1 parent 244cd5d
commit 88a748d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/rules/no-identical-expressions.ts b/src/rules/no-identical-expressions.ts
@@ -53,7 +53,11 @@ function hasIdentifierOperands(node: TSESTree.BinaryExpression | TSESTree.Logica
 }
 
 function isOneOntoOneShifting(node: TSESTree.BinaryExpression | TSESTree.LogicalExpression) {
-  return node.operator === '<<' && isLiteral(node.left) && node.left.value === 1;
+  return (
+    node.operator === '<<' &&
+    isLiteral(node.left) &&
+    (node.left.value === 1 || node.left.value === 1n)
+  );
 }
 
 const message =

diff --git a/tests/rules/no-identical-expressions.test.ts b/tests/rules/no-identical-expressions.test.ts
@@ -23,6 +23,7 @@ import rule = require('../../src/rules/no-identical-expressions');
 ruleTester.run('no-identical-expressions', rule, {
   valid: [
     { code: `1 << 1;` },
+    { code: `1n << 1n;` },
     { code: `foo(), foo();` },
     { code: `if (Foo instanceof Foo) { }` },
     {

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es2015",
+    "target": "es2020",
     "module": "commonjs",
     "lib": ["es2017"],
     "strict": true,