Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update css:S4653 ('unit-no-unknown'): Drop obsolete hardcoded configuration #3108

Merged
merged 1 commit into from Apr 12, 2022
Merged

Update css:S4653 ('unit-no-unknown'): Drop obsolete hardcoded configuration #3108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 0 additions & 12 deletions ...javascript-plugin/src/main/java/org/sonar/plugins/javascript/css/rules/UnitNoUnknown.java
View file
Open in desktop
Expand Up @@ -19,8 +19,6 @@
*/
package org.sonar.plugins.javascript.css.rules;

import java.util.Arrays;
import java.util.List;
import org.sonar.check.Rule;

@Rule(key = "S4653")
Expand All @@ -30,14 +28,4 @@ public class UnitNoUnknown implements CssRule {
public String stylelintKey() {
return "unit-no-unknown";
}

@Override
public List<Object> stylelintOptions() {
return Arrays.asList(true, new StylelintIgnoreOption());
}

private static class StylelintIgnoreOption {
// Used by GSON serialization
private final String[] ignoreUnits = {"x"};
}
}
9 changes: 1 addition & 8 deletions ...r-javascript-plugin/src/test/java/org/sonar/plugins/javascript/css/rules/CssRuleTest.java
View file
Open in desktop
Expand Up @@ -48,8 +48,7 @@ void rules_default_is_empty() throws NoSuchMethodException, IllegalAccessExcepti
PropertyNoUnknown.class,
SelectorPseudoClassNoUnknown.class,
SelectorPseudoElementNoUnknown.class,
SelectorTypeNoUnknown.class,
UnitNoUnknown.class);
SelectorTypeNoUnknown.class);

for (Class ruleClass : CssRules.getRuleClasses()) {
CssRule rule = (CssRule)ruleClass.getConstructor().newInstance();
Expand Down Expand Up @@ -106,12 +105,6 @@ void selector_pseudo_element_no_unknown_custom() {
assertThat(optionsAsJson).isEqualTo("[true,{\"ignorePseudoElements\":[\"ng-deep\",\"/^custom-/\"]}]");
}

@Test
void units_no_unknown_options() {
String optionsAsJson = new Gson().toJson(new UnitNoUnknown().stylelintOptions());
assertThat(optionsAsJson).isEqualTo("[true,{\"ignoreUnits\":[\"x\"]}]");
}

@Test
void at_rule_unknown_default() {
String optionsAsJson = new Gson().toJson(new AtRuleNoUnknown().stylelintOptions());
Expand Down