Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2757

Merged
merged 9 commits into from Aug 13, 2021
Merged

Update dependencies #2757

merged 9 commits into from Aug 13, 2021

Conversation

vilchik-elena
Copy link
Contributor

@vilchik-elena vilchik-elena commented Aug 12, 2021

Fixes #2753

I added _ to the default list of globals. Note that the rule behaviour didn't change with new ESLint version (unit test added), I believe there is something in ESLint environments set up has changed, while I didn't manage to find the root cause.

P.S. ESLint is taking globals for each environment from globals package

@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 90%)

See analysis details on SonarQube

@saberduck saberduck merged commit 2390015 into master Aug 13, 2021
@saberduck saberduck deleted the issue-2753 branch August 13, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade typescript-eslint, babel and eslint dependencies
2 participants