Upgrade ESLint to 7.5.0 and typescript-eslint to 3.7.1 #2038

saberduck · 2020-07-16T15:03:57Z

Bump of dependencies

eslint to 7.5.0
typescript-eslint to 3.7.1
- this change makes us to support different range of TypeScript: >=3.3.1 <4.0.0 (technically we test against 3.10.0 to exclude 4.0.0 see https://github.com/typescript-eslint/typescript-eslint/blob/5eedbff01178ea33b98ab22e556df4c1a195f839/packages/typescript-estree/src/parser.ts#L23 )

Changes in ruling are related to improvements in eslint

Update: no-self-assign should detect member expression with this eslint/eslint#12279 for S1656
Breaking: make no-redeclare stricter (fixes #11370, fixes #11405) eslint/eslint#11509 for S2814
Update: curly should check consequent if statements eslint/eslint#12947 for S121

saberduck · 2020-07-24T20:59:24Z

see #2041

vilchik-elena · 2020-07-30T08:40:55Z

eslint-bridge/src/rules/no-globals-shadowing.ts

@@ -90,7 +90,7 @@ function reportBadUsage(
        break;
      case 'ObjectPattern':
        node.properties.forEach(prop => {
-          reportBadUsage(prop.value, buildMessage, context);
+          reportBadUsage((prop as estree.AssignmentProperty).value, buildMessage, context);


so if prop is RestElement we will pass undefined as first argument to reportBadUsage. It will work as expected but I'm not sure such casting to estree.AssignmentProperty is clear about this between-the-lines logic.

I rewrote this to properly handle RestElement case, it also improves the rule to detect patterns like const {x, ...eval} = foo()

vilchik-elena · 2020-07-30T08:49:24Z

eslint-bridge/src/rules/no-unenclosed-multiline-block.ts

@@ -46,6 +46,8 @@ export const rule: Rule.RuleModule = {
      Program: (node: estree.Node) => checkStatements((node as estree.Program).body, context),
      BlockStatement: (node: estree.Node) =>
        checkStatements((node as estree.BlockStatement).body, context),
+      TSModuleBlock: (node: estree.Node) =>
+        checkStatements(((node as unknown) as TSESTree.TSModuleBlock).body as Statement[], context),


in fact this is a fix for FN. Do you think it deserves a separate ticket in backlog?

I think this is minor improvement, let's keep it here

vilchik-elena · 2020-07-30T08:52:01Z

eslint-bridge/src/rules/no-unenclosed-multiline-block.ts

@@ -145,7 +147,7 @@ function raiseInlineAndIndentedIssue(
  });
 }

-function isNestingStatement(node: estree.Node): node is NestingStatement {
+function isNestingStatement(node: estree.Node | TSESTree.Node): node is NestingStatement {


I don't think this change is required

vilchik-elena · 2020-07-30T08:54:56Z

eslint-bridge/src/rules/no-duplicate-in-composite.ts

        const sourceCode = context.getSourceCode();
        const compositeType = (node as unknown) as
          | TSESTree.TSUnionType
          | TSESTree.TSIntersectionType;
        const groupedTypes: Map<string, Array<TSESTree.Node>> = new Map();

        compositeType.types.forEach(typescriptType => {
-          const nodeValue = sourceCode.getText(typescriptType as estree.Node);
+          const nodeValue = sourceCode.getText((typescriptType as unknown) as estree.Node);


why did it compile before? without as unknown

something has changed in the type definitions that they don't overlap anymore, I didn't dig deeper

I think some types are out of sync between TSESTree and estree

vilchik-elena · 2020-07-30T08:57:31Z

eslint-bridge/src/rules/os-command.ts

@@ -91,7 +91,7 @@ function containsShellOption(otherArguments: Argument[]) {
  return otherArguments.some(
    arg =>
      arg.type === 'ObjectExpression' &&
-      arg.properties.some(
+      (arg.properties as estree.Property[]).some(


what will happen to SpreadElement property?

I fixed the rule to handle SpreadElement

vilchik-elena · 2020-07-30T09:10:35Z

eslint-bridge/src/parser.ts

-const TYPESCRIPT_MINIMUM_VERSION = '3.2.1';
-const TYPESCRIPT_MAXIMUM_VERSION = '3.8.0';
+const TYPESCRIPT_MINIMUM_VERSION = '3.3.1';
+const TYPESCRIPT_MAXIMUM_VERSION = '3.10.0';


where does this version come from? I see <4.0.0 for typescript-eslint

https://github.com/typescript-eslint/typescript-eslint/blob/5eedbff01178ea33b98ab22e556df4c1a195f839/packages/typescript-estree/src/parser.ts#L23

vilchik-elena · 2020-07-30T09:12:19Z

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/TypeScriptAnalysisTest.java

  }

  @Test
  public void test_new_typescript() throws Exception {
    File dir = TestUtils.projectDir("tsproject-no-typescript");
-    TestUtils.npmInstall(dir, "typescript@3.8.0-dev.20191026", "--no-save");
+    String tsVersion = "4.0.0-beta";


btw it seems to be supported https://github.com/typescript-eslint/typescript-eslint/blob/817067b72b53c8f417f3c1c85e970ea82f0f6953/package.json#L101

hm, do you think it's an issue? I would keep as is

vilchik-elena · 2020-07-30T09:13:21Z

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/TypeScriptVersionsTest.java

@@ -69,6 +69,7 @@ public void test() throws Exception {

    String projectKey = "tsproject-test-ts-version-" + tsVersion;
    SonarScanner build = SonarScanner.create()
+      .setDebugLogs(true)


do we want to keep this?

no, removed

vilchik-elena · 2020-07-30T09:14:23Z

its/ruling/src/test/expected/js/amplify/javascript-S104.json

@@ -1,5 +1,5 @@
 {


do we have eslint issue for this change?

eslint/eslint#13318

vilchik-elena · 2020-07-30T09:15:05Z

its/ruling/src/test/expected/js/angular.js/javascript-S1656.json

@@ -0,0 +1,7 @@
+{


same here, it will be nice to list in the PR eslint issues causing these changes

eslint/eslint#12279

vilchik-elena · 2020-07-30T12:48:54Z

eslint-bridge/src/parser.ts


 // this value is taken from typescript-estree
 // still we might consider extending this range
 // if everything which we need is working on older/newer versions
-const TYPESCRIPT_MINIMUM_VERSION = '3.2.1';
-const TYPESCRIPT_MAXIMUM_VERSION = '3.8.0';
+const TYPESCRIPT_MINIMUM_VERSION = '3.3.1';


we should update documentation.md

vilchik-elena

LGTM, but remove unused config for test without tsconfig.
Also we should find eslint tickets in rules S2814 and S121

vilchik-elena · 2020-07-31T07:47:56Z

eslint-bridge/tests/RuleTesterTs.ts

@@ -62,13 +62,6 @@ class RuleTesterTs extends RuleTester {
      invalid?: RuleTester.InvalidTestCase[];
    },
  ): void {
-    if (this.expectNoIssuesWithoutTypes) {
-      this.ruleTesterNoTsConfig.run(`${name}[noTsConfig]`, rule, {


@saberduck not handled

sonarsource-next · 2020-07-31T08:32:39Z

Kudos, SonarQube Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

saberduck force-pushed the tibor/upgrade_eslint7 branch from 8178479 to cf9a7ca Compare July 24, 2020 20:17

saberduck force-pushed the tibor/upgrade_eslint7 branch 5 times, most recently from c306b04 to a2f2f21 Compare July 29, 2020 14:51

saberduck requested a review from vilchik-elena July 30, 2020 07:16

saberduck marked this pull request as ready for review July 30, 2020 07:16

vilchik-elena requested changes Jul 30, 2020

View reviewed changes

vilchik-elena added this to the 6.4 milestone Jul 30, 2020

vilchik-elena added the dependencies label Jul 30, 2020

vilchik-elena reviewed Jul 30, 2020

View reviewed changes

vilchik-elena changed the title ~~Upgrade to Eslint7~~ Upgrade ESLint to 7 Jul 30, 2020

vilchik-elena changed the title ~~Upgrade ESLint to 7~~ Upgrade ESLint to 7.5.0 and typescript-eslint to 3.7.1 Jul 30, 2020

vilchik-elena assigned saberduck Jul 30, 2020

saberduck force-pushed the tibor/upgrade_eslint7 branch 2 times, most recently from 9853780 to aa09234 Compare July 30, 2020 20:56

saberduck mentioned this pull request Jul 30, 2020

linter init eslint7 #2046

Closed

saberduck added 6 commits July 31, 2020 08:33

Upgrade ESLint 7.4.0 and @typescript-eslint 3.7.1. Fix tests

f42fd2d

Bump minimal supported version of TS to >= 3.3.1 < 3.9.0

b259c00

Update ruling - improvements in S1656 and S2814

8545085

Update TS ruling - S121

4d9a63f

review feedback

ee48d96

fix supported TS version

4cd6ae2

saberduck force-pushed the tibor/upgrade_eslint7 branch from aa09234 to 4cd6ae2 Compare July 31, 2020 06:39

saberduck requested a review from vilchik-elena July 31, 2020 07:02

vilchik-elena approved these changes Jul 31, 2020

View reviewed changes

Remove unused field and refactor duplication

745039d

vilchik-elena force-pushed the tibor/upgrade_eslint7 branch from a7e0d06 to 745039d Compare July 31, 2020 08:27

vilchik-elena merged commit dc7eb58 into master Jul 31, 2020

vilchik-elena deleted the tibor/upgrade_eslint7 branch July 31, 2020 09:01

vilchik-elena mentioned this pull request Aug 10, 2020

Require Node 10 #2054

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ESLint to 7.5.0 and typescript-eslint to 3.7.1 #2038

Upgrade ESLint to 7.5.0 and typescript-eslint to 3.7.1 #2038

saberduck commented Jul 16, 2020 •

edited by vilchik-elena

saberduck commented Jul 24, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

saberduck Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

vilchik-elena Jul 31, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

saberduck Jul 30, 2020

vilchik-elena Jul 30, 2020

vilchik-elena left a comment

vilchik-elena Jul 31, 2020

sonarsource-next bot commented Jul 31, 2020

Upgrade ESLint to 7.5.0 and typescript-eslint to 3.7.1 #2038

Upgrade ESLint to 7.5.0 and typescript-eslint to 3.7.1 #2038

Conversation

saberduck commented Jul 16, 2020 • edited by vilchik-elena

saberduck commented Jul 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vilchik-elena left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarsource-next bot commented Jul 31, 2020

saberduck commented Jul 16, 2020 •

edited by vilchik-elena