Skip to content

Commit

Permalink
Update CSS plugin expectations
Browse files Browse the repository at this point in the history
- New issues of S4650 are due to a reimplementation of the rule (see stylelint/stylelint#5636)
- Old issues of S5362 are due to our custom reimplementation of the dropped rule
- Old issue of S4654 seemed to be a false positive, but it's unclear why the issue disappeared
  • Loading branch information
yassin-kammoun-sonarsource committed Apr 6, 2022
1 parent 2758d9d commit 6cdff3e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion its/plugin/projects/css-issues-project/src/file1.css
Expand Up @@ -34,7 +34,7 @@ a:unknown { /* S4659 | selecto
width: calc(100% 80px); /* S5362 | function-calc-no-invalid */
}

//color: pink; /* S4668 | no-invalid-double-slash-comments */ /* S4654 | property-no-unknown */
//color: pink; /* S4668 | no-invalid-double-slash-comments */

.class1 {
width: 100px;
Expand Down
Expand Up @@ -98,9 +98,10 @@ void issue_list() {
tuple("css:S4654", "css-issues-project:src/file1.css"),
tuple("css:S4657", "css-issues-project:src/file1.css"),
tuple("css:S4650", "css-issues-project:src/file1.css"),
tuple("css:S4650", "css-issues-project:src/file1.css"),
tuple("css:S4650", "css-issues-project:src/file1.css"),
tuple("css:S4653", "css-issues-project:src/file1.css"),
tuple("css:S4668", "css-issues-project:src/file1.css"),
tuple("css:S4654", "css-issues-project:src/file1.css"),
tuple("css:S4651", "css-issues-project:src/file1.css"),
tuple("css:S4666", "css-issues-project:src/file1.css"),
tuple("css:S4670", "css-issues-project:src/file1.css"),
Expand All @@ -122,6 +123,8 @@ void issue_list() {
tuple("css:S4654", "css-issues-project:src/file2.less"),
tuple("css:S4657", "css-issues-project:src/file2.less"),
tuple("css:S4650", "css-issues-project:src/file2.less"),
tuple("css:S4650", "css-issues-project:src/file2.less"),
tuple("css:S4650", "css-issues-project:src/file2.less"),
tuple("css:S4653", "css-issues-project:src/file2.less"),
tuple("css:S4651", "css-issues-project:src/file2.less"),
tuple("css:S4666", "css-issues-project:src/file2.less"),
Expand All @@ -144,6 +147,8 @@ void issue_list() {
tuple("css:S4654", "css-issues-project:src/file3.scss"),
tuple("css:S4657", "css-issues-project:src/file3.scss"),
tuple("css:S4650", "css-issues-project:src/file3.scss"),
tuple("css:S4650", "css-issues-project:src/file3.scss"),
tuple("css:S4650", "css-issues-project:src/file3.scss"),
tuple("css:S4653", "css-issues-project:src/file3.scss"),
tuple("css:S4651", "css-issues-project:src/file3.scss"),
tuple("css:S4666", "css-issues-project:src/file3.scss"),
Expand All @@ -155,13 +160,7 @@ void issue_list() {
tuple("css:S1116", "css-issues-project:src/file5.htm"),
tuple("css:S1116", "css-issues-project:src/file6.vue"),
tuple("css:S5362", "css-issues-project:src/file1.css"),
tuple("css:S5362", "css-issues-project:src/file1.css"),
tuple("css:S5362", "css-issues-project:src/file1.css"),
tuple("css:S5362", "css-issues-project:src/file2.less"),
tuple("css:S5362", "css-issues-project:src/file2.less"),
tuple("css:S5362", "css-issues-project:src/file2.less"),
tuple("css:S5362", "css-issues-project:src/file3.scss"),
tuple("css:S5362", "css-issues-project:src/file3.scss"),
tuple("css:S5362", "css-issues-project:src/file3.scss")
);
}
Expand Down

0 comments on commit 6cdff3e

Please sign in to comment.