Enable support of JavaScript experimental class properties with Babel…

… parser (#2751)
SonarSource · Aug 12, 2021 · 02f1309 · 02f1309
1 parent 651bb50
commit 02f1309
Show file tree

Hide file tree

Showing 5 changed files with 1,001 additions and 17 deletions.
diff --git a/eslint-bridge/package.json b/eslint-bridge/package.json
@@ -42,6 +42,7 @@
   "dependencies": {
     "@babel/core": "7.13.15",
     "@babel/eslint-parser": "7.13.14",
+    "@babel/preset-env": "7.15.0",
     "@babel/preset-flow": "7.13.13",
     "@babel/preset-react": "7.13.13",
     "@typescript-eslint/eslint-plugin": "4.26.0",
@@ -64,6 +65,7 @@
     "@typescript-eslint/parser",
     "@babel/core",
     "@babel/eslint-parser",
+    "@babel/preset-env",
     "@babel/preset-flow",
     "@babel/preset-react",
     "builtin-modules",

diff --git a/eslint-bridge/src/parser.ts b/eslint-bridge/src/parser.ts
@@ -194,7 +194,11 @@ export function parseExceptionCodeOf(exceptionMsg: string): ParseExceptionCode {
 function babelConfig(config: Linter.ParserOptions) {
   const pluginPath = `${__dirname}/../node_modules`;
   const babelOptions = {
-    presets: [`${pluginPath}/@babel/preset-react`, `${pluginPath}/@babel/preset-flow`],
+    presets: [
+      `${pluginPath}/@babel/preset-react`,
+      `${pluginPath}/@babel/preset-flow`,
+      `${pluginPath}/@babel/preset-env`,
+    ],
     babelrc: false,
     configFile: false,
   };

diff --git a/eslint-bridge/tests/parser.test.ts b/eslint-bridge/tests/parser.test.ts
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-import { ParseExceptionCode, parseExceptionCodeOf } from 'parser';
+import { buildSourceCode, ParseExceptionCode, parseExceptionCodeOf } from 'parser';
 import { SourceCode } from 'eslint';
 import { ParsingError } from 'analyzer';
 import { visit } from '../src/utils';
@@ -157,6 +157,16 @@ import { ParseExceptionCode } from '../src/parser';
     const message = `DEBUG Failed to parse foo.vue with TypeScript compiler: '}' expected.`;
     expect(callsToLogger.filter(args => args[0] === message)).toHaveLength(1);
   });
+
+  it(`should parse experimental class properties with Babel parser`, () => {
+    const code = ` class C { #f = 42; #m() {} }`;
+    setContext({ workDir: '', shouldUseTypeScriptParserForJS: false, sonarlint: false });
+    const sourceCode = buildSourceCode(
+      { filePath: '/some/path', fileContent: code },
+      'js',
+    ) as SourceCode;
+    expect(sourceCode.ast).toBeDefined();
+  });
 });
 
 describe('parseTypeScriptSourceFile', () => {