[bep-1279]Fixed keyword arguments for ruby update to 3.1.4 in application-form app #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serjpetrenko
changed the title
lorint
approved these changes
Oct 13, 2023
v-lunyov-ep
approved these changes
Oct 13, 2023
I think |
| @@ -51,7 +51,7 @@ def attachment(*attachment_names) | |||
| attachment_names.each do |attachment_name| | |||
| COLUMNS.each_pair do |column_name, column_type| | |||
| column_options = options.merge(options[column_name.to_sym] || {}) | |||
| column("#{attachment_name}_#{column_name}", column_type, column_options) | |||
| column("#{attachment_name}_#{column_name}", column_type, **column_options) | |||
There was a problem hiding this comment.
Did it break our CI or was it just failing on bundling?
Just curious how you find that has to be changed.
There was a problem hiding this comment.
It was failed during the rake db:migrate on CI, so I found a failed migration with attachement type field and understood that it comes from paperclip.
ramantsekhanau
approved these changes
Oct 13, 2023
|
Don't forget to push tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed keyword arguments for ruby update to 3.2.2 in application-form app
https://sohohousedev.atlassian.net/browse/BEP-1279