Added UAEPass Provider #1203
Open
Added UAEPass Provider #1203
+277
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atymic
requested changes
Jun 8, 2024
src/UAEPass/README.md
Outdated
| 'uaepass' => [ | ||
| 'client_id' => env('UAEPASS_CLIENT_ID'), | ||
| 'client_secret' => env('UAEPAS_CLIENT_SECRET'), | ||
| 'redirect' => env('UAEPAS_REDIRECT_URI') |
…nfig and other code cleanup
…nvironment variable
Co-authored-by: atymic <atymicq@gmail.com>
atymic
reviewed
Jun 10, 2024
src/UAEPass/README.md
Outdated
| 'base_url' => env('UAEPASS_BASE_URL'), | ||
| 'client_id' => env('UAEPASS_CLIENT_ID'), | ||
| 'client_secret' => env('UAEPAS_CLIENT_SECRET'), | ||
| 'redirect' => env('UAEPAS_REDIRECT_URI') |
There was a problem hiding this comment.
to use $this->getConfig('base_url') you need to add base_url here
There was a problem hiding this comment.
Please correct me if I'm wrong ? base_url is already added in env as UAEPASS_BASE_URL
There was a problem hiding this comment.
It needs to be added to the config in services.php or getConfig with the additional config keys wont find it
There was a problem hiding this comment.
Updated with default base_url in ReadMe 3caf8cb
There was a problem hiding this comment.
I have tested and it's working fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds UAE Pass provider.
Official UAEPass Website